626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
96 lines
2.4 KiB
C++
96 lines
2.4 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2022, Ideas on Board Oy.
|
|
*
|
|
* Stream colorspace adjustment test
|
|
*/
|
|
|
|
#include <iostream>
|
|
|
|
#include <libcamera/camera.h>
|
|
#include <libcamera/formats.h>
|
|
#include <libcamera/stream.h>
|
|
|
|
#include "test.h"
|
|
|
|
using namespace libcamera;
|
|
using namespace std;
|
|
|
|
class TestCameraConfiguration : public CameraConfiguration
|
|
{
|
|
public:
|
|
TestCameraConfiguration()
|
|
: CameraConfiguration()
|
|
{
|
|
}
|
|
|
|
Status validate() override
|
|
{
|
|
return validateColorSpaces();
|
|
}
|
|
};
|
|
|
|
class StreamColorSpaceTest : public Test
|
|
{
|
|
protected:
|
|
int run()
|
|
{
|
|
TestCameraConfiguration config;
|
|
|
|
StreamConfiguration cfg;
|
|
cfg.size = { 640, 320 };
|
|
cfg.pixelFormat = formats::YUV422;
|
|
cfg.colorSpace = ColorSpace::Srgb;
|
|
config.addConfiguration(cfg);
|
|
|
|
StreamConfiguration &streamCfg = config.at(0);
|
|
|
|
/*
|
|
* YUV pixelformat with sRGB colorspace should have Y'CbCr encoding
|
|
* adjusted.
|
|
*/
|
|
config.validate();
|
|
if (streamCfg.colorSpace->ycbcrEncoding == ColorSpace::YcbcrEncoding::None) {
|
|
cerr << "YUV format must have YCbCr encoding" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* For YUV pixelFormat, encoding should be picked up according
|
|
* to primaries and transfer function, if 'None' is specified.
|
|
*/
|
|
streamCfg.pixelFormat = formats::YUV422;
|
|
streamCfg.colorSpace = ColorSpace(ColorSpace::Primaries::Rec2020,
|
|
ColorSpace::TransferFunction::Rec709,
|
|
ColorSpace::YcbcrEncoding::None,
|
|
ColorSpace::Range::Limited);
|
|
config.validate();
|
|
if (streamCfg.colorSpace->ycbcrEncoding != ColorSpace::YcbcrEncoding::Rec2020) {
|
|
cerr << "Failed to adjust colorspace Y'CbCr encoding according"
|
|
<< " to primaries and transfer function" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* For RGB pixelFormat, Sycc colorspace should get adjusted to sRGB. */
|
|
streamCfg.pixelFormat = formats::RGB888;
|
|
streamCfg.colorSpace = ColorSpace::Sycc;
|
|
config.validate();
|
|
if (streamCfg.colorSpace != ColorSpace::Srgb) {
|
|
cerr << "RGB format's colorspace should be set to Srgb" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Raw formats should always set colorspace to ColorSpace::Raw. */
|
|
streamCfg.pixelFormat = formats::SBGGR8;
|
|
streamCfg.colorSpace = ColorSpace::Rec709;
|
|
config.validate();
|
|
if (streamCfg.colorSpace != ColorSpace::Raw) {
|
|
cerr << "Raw format must always have Raw colorspace" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
};
|
|
|
|
TEST_REGISTER(StreamColorSpaceTest)
|