libcamera/test/serialization/control_serialization.cpp
Laurent Pinchart 93e72b695e libcamera: Move internal headers to include/libcamera/internal/
The libcamera internal headers are located in src/libcamera/include/.
The directory is added to the compiler headers search path with a meson
include_directories() directive, and internal headers are included with
(e.g. for the internal semaphore.h header)

  #include "semaphore.h"

All was well, until libcxx decided to implement the C++20
synchronization library. The __threading_support header gained a

  #include <semaphore.h>

to include the pthread's semaphore support. As include_directories()
adds src/libcamera/include/ to the compiler search path with -I, the
internal semaphore.h is included instead of the pthread version.
Needless to say, the compiler isn't happy.

Three options have been considered to fix this issue:

- Use -iquote instead of -I. The -iquote option instructs gcc to only
  consider the header search path for headers included with the ""
  version. Meson unfortunately doesn't support this option.

- Rename the internal semaphore.h header. This was deemed to be the
  beginning of a long whack-a-mole game, where namespace clashes with
  system libraries would appear over time (possibly dependent on
  particular system configurations) and would need to be constantly
  fixed.

- Move the internal headers to another directory to create a unique
  namespace through path components. This causes lots of churn in all
  the existing source files through the all project.

The first option would be best, but isn't available to us due to missing
support in meson. Even if -iquote support was added, we would need to
fix the problem before a new version of meson containing the required
support would be released.

The third option is thus the only practical solution available. Bite the
bullet, and do it, moving headers to include/libcamera/internal/.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
2020-05-16 03:38:11 +03:00

167 lines
4.1 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* control_serialization.cpp - Serialize and deserialize controls
*/
#include <iostream>
#include <libcamera/camera.h>
#include <libcamera/control_ids.h>
#include <libcamera/controls.h>
#include "libcamera/internal/byte_stream_buffer.h"
#include "libcamera/internal/control_serializer.h"
#include "serialization_test.h"
#include "test.h"
using namespace std;
using namespace libcamera;
class ControlSerializationTest : public SerializationTest
{
protected:
int init() override
{
return status_;
}
int run() override
{
ControlSerializer serializer;
ControlSerializer deserializer;
std::vector<uint8_t> infoData;
std::vector<uint8_t> listData;
size_t size;
int ret;
/* Create a control list with three controls. */
const ControlInfoMap &infoMap = camera_->controls();
ControlList list(infoMap);
list.set(controls::Brightness, 0.5f);
list.set(controls::Contrast, 1.2f);
list.set(controls::Saturation, 0.2f);
/*
* Serialize the control list, this should fail as the control
* info map hasn't been serialized.
*/
size = serializer.binarySize(list);
listData.resize(size);
ByteStreamBuffer buffer(listData.data(), listData.size());
ret = serializer.serialize(list, buffer);
if (!ret) {
cerr << "List serialization without info map should have failed"
<< endl;
return TestFail;
}
if (buffer.overflow() || buffer.offset()) {
cerr << "Failed list serialization modified the buffer"
<< endl;
return TestFail;
}
/* Serialize the control info map. */
size = serializer.binarySize(infoMap);
infoData.resize(size);
buffer = ByteStreamBuffer(infoData.data(), infoData.size());
ret = serializer.serialize(infoMap, buffer);
if (ret < 0) {
cerr << "Failed to serialize ControlInfoMap" << endl;
return TestFail;
}
if (buffer.overflow()) {
cerr << "Overflow when serializing ControlInfoMap" << endl;
return TestFail;
}
/* Serialize the control list, this should now succeed. */
size = serializer.binarySize(list);
listData.resize(size);
buffer = ByteStreamBuffer(listData.data(), listData.size());
ret = serializer.serialize(list, buffer);
if (ret) {
cerr << "Failed to serialize ControlList" << endl;
return TestFail;
}
if (buffer.overflow()) {
cerr << "Overflow when serializing ControlList" << endl;
return TestFail;
}
/*
* Deserialize the control list, this should fail as the control
* info map hasn't been deserialized.
*/
buffer = ByteStreamBuffer(const_cast<const uint8_t *>(listData.data()),
listData.size());
ControlList newList = deserializer.deserialize<ControlList>(buffer);
if (!newList.empty()) {
cerr << "List deserialization without info map should have failed"
<< endl;
return TestFail;
}
if (buffer.overflow()) {
cerr << "Failed list deserialization modified the buffer"
<< endl;
return TestFail;
}
/* Deserialize the control info map and verify the contents. */
buffer = ByteStreamBuffer(const_cast<const uint8_t *>(infoData.data()),
infoData.size());
ControlInfoMap newInfoMap = deserializer.deserialize<ControlInfoMap>(buffer);
if (newInfoMap.empty()) {
cerr << "Failed to deserialize ControlInfoMap" << endl;
return TestFail;
}
if (buffer.overflow()) {
cerr << "Overflow when deserializing ControlInfoMap" << endl;
return TestFail;
}
if (!equals(infoMap, newInfoMap)) {
cerr << "Deserialized map doesn't match original" << endl;
return TestFail;
}
/* Deserialize the control list and verify the contents. */
buffer = ByteStreamBuffer(const_cast<const uint8_t *>(listData.data()),
listData.size());
newList = deserializer.deserialize<ControlList>(buffer);
if (newList.empty()) {
cerr << "Failed to deserialize ControlList" << endl;
return TestFail;
}
if (buffer.overflow()) {
cerr << "Overflow when deserializing ControlList" << endl;
return TestFail;
}
if (!equals(list, newList)) {
cerr << "Deserialized list doesn't match original" << endl;
return TestFail;
}
return TestPass;
}
};
TEST_REGISTER(ControlSerializationTest)