The CameraConfiguration class implements a simple storage of StreamConfiguration with internal validation limited to verifying that the stream configurations are not empty. Extend this mechanism by implementing a smart validate() method backed by pipeline handlers. This new mechanism changes the semantic of the camera configuration. The Camera::generateConfiguration() operation still generates a default configuration based on roles, but now also supports generating empty configurations to be filled by applications. Applications can inspect the configuration, optionally modify it, and validate it. The validation implements "try" semantics and adjusts invalid configurations instead of rejecting them completely. Applications then decide whether to accept the modified configuration, or try again with a different set of parameters. Once the configuration is valid, it is passed to Camera::configure(), and pipeline handlers are guaranteed that the configuration they receive is valid. A reference to the Camera may need to be stored in the CameraConfiguration derived classes in order to access it from their validate() implementation. This must be stored as a std::shared_ptr<> as the CameraConfiguration instances belong to applications. In order to make this possible, make the Camera class inherit from std::shared_from_this<>. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
150 lines
3.3 KiB
C++
150 lines
3.3 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* libcamera Camera API tests
|
|
*/
|
|
|
|
#include <iostream>
|
|
|
|
#include "camera_test.h"
|
|
|
|
using namespace std;
|
|
|
|
namespace {
|
|
|
|
class Capture : public CameraTest
|
|
{
|
|
protected:
|
|
unsigned int completeBuffersCount_;
|
|
unsigned int completeRequestsCount_;
|
|
|
|
void bufferComplete(Request *request, Buffer *buffer)
|
|
{
|
|
if (buffer->status() != Buffer::BufferSuccess)
|
|
return;
|
|
|
|
completeBuffersCount_++;
|
|
}
|
|
|
|
void requestComplete(Request *request, const std::map<Stream *, Buffer *> &buffers)
|
|
{
|
|
if (request->status() != Request::RequestComplete)
|
|
return;
|
|
|
|
completeRequestsCount_++;
|
|
|
|
/* Reuse the buffers for a new request. */
|
|
request = camera_->createRequest();
|
|
request->setBuffers(buffers);
|
|
camera_->queueRequest(request);
|
|
}
|
|
|
|
int init() override
|
|
{
|
|
CameraTest::init();
|
|
|
|
config_ = camera_->generateConfiguration({ StreamRole::VideoRecording });
|
|
if (!config_ || config_->size() != 1) {
|
|
cout << "Failed to generate default configuration" << endl;
|
|
CameraTest::cleanup();
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run() override
|
|
{
|
|
StreamConfiguration &cfg = config_->at(0);
|
|
|
|
if (camera_->acquire()) {
|
|
cout << "Failed to acquire the camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (camera_->configure(config_.get())) {
|
|
cout << "Failed to set default configuration" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (camera_->allocateBuffers()) {
|
|
cout << "Failed to allocate buffers" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
Stream *stream = cfg.stream();
|
|
BufferPool &pool = stream->bufferPool();
|
|
std::vector<Request *> requests;
|
|
for (Buffer &buffer : pool.buffers()) {
|
|
Request *request = camera_->createRequest();
|
|
if (!request) {
|
|
cout << "Failed to create request" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
std::map<Stream *, Buffer *> map = { { stream, &buffer } };
|
|
if (request->setBuffers(map)) {
|
|
cout << "Failed to associating buffer with request" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
requests.push_back(request);
|
|
}
|
|
|
|
completeRequestsCount_ = 0;
|
|
completeBuffersCount_ = 0;
|
|
|
|
camera_->bufferCompleted.connect(this, &Capture::bufferComplete);
|
|
camera_->requestCompleted.connect(this, &Capture::requestComplete);
|
|
|
|
if (camera_->start()) {
|
|
cout << "Failed to start camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
for (Request *request : requests) {
|
|
if (camera_->queueRequest(request)) {
|
|
cout << "Failed to queue request" << endl;
|
|
return TestFail;
|
|
}
|
|
}
|
|
|
|
EventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();
|
|
|
|
Timer timer;
|
|
timer.start(100);
|
|
while (timer.isRunning())
|
|
dispatcher->processEvents();
|
|
|
|
if (completeRequestsCount_ <= cfg.bufferCount * 2) {
|
|
cout << "Failed to capture enough frames (got "
|
|
<< completeRequestsCount_ << " expected at least "
|
|
<< cfg.bufferCount * 2 << ")" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (completeRequestsCount_ != completeBuffersCount_) {
|
|
cout << "Number of completed buffers and requests differ" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (camera_->stop()) {
|
|
cout << "Failed to stop camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (camera_->freeBuffers()) {
|
|
cout << "Failed to free buffers" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
std::unique_ptr<CameraConfiguration> config_;
|
|
};
|
|
|
|
} /* namespace */
|
|
|
|
TEST_REGISTER(Capture);
|