3335d5a504
Many signals used in internal and public APIs carry the emitter pointer as a signal argument. This was done to allow slots connected to multiple signal instances to differentiate between emitters. While starting from a good intention of facilitating the implementation of slots, it turned out to be a bad API design as the signal isn't meant to know what it will be connected to, and thus shouldn't carry parameters that are solely meant to support a use case specific to the connected slot. These pointers turn out to be unused in all slots but one. In the only case where it is needed, it can be obtained by wrapping the slot in a lambda function when connecting the signal. Do so, and drop the emitter pointer from all signals. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
78 lines
1.5 KiB
C++
78 lines
1.5 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* thread.h - Thread support
|
|
*/
|
|
#ifndef __LIBCAMERA_BASE_THREAD_H__
|
|
#define __LIBCAMERA_BASE_THREAD_H__
|
|
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <sys/types.h>
|
|
#include <thread>
|
|
|
|
#include <libcamera/base/private.h>
|
|
|
|
#include <libcamera/base/message.h>
|
|
#include <libcamera/base/signal.h>
|
|
#include <libcamera/base/utils.h>
|
|
|
|
namespace libcamera {
|
|
|
|
class EventDispatcher;
|
|
class Message;
|
|
class Object;
|
|
class ThreadData;
|
|
class ThreadMain;
|
|
|
|
using Mutex = std::mutex;
|
|
using MutexLocker = std::unique_lock<std::mutex>;
|
|
|
|
class Thread
|
|
{
|
|
public:
|
|
Thread();
|
|
virtual ~Thread();
|
|
|
|
void start();
|
|
void exit(int code = 0);
|
|
bool wait(utils::duration duration = utils::duration::max());
|
|
|
|
bool isRunning();
|
|
|
|
Signal<> finished;
|
|
|
|
static Thread *current();
|
|
static pid_t currentId();
|
|
|
|
EventDispatcher *eventDispatcher();
|
|
|
|
void dispatchMessages(Message::Type type = Message::Type::None);
|
|
|
|
protected:
|
|
int exec();
|
|
virtual void run();
|
|
|
|
private:
|
|
void startThread();
|
|
void finishThread();
|
|
|
|
void postMessage(std::unique_ptr<Message> msg, Object *receiver);
|
|
void removeMessages(Object *receiver);
|
|
|
|
friend class Object;
|
|
friend class ThreadData;
|
|
friend class ThreadMain;
|
|
|
|
void moveObject(Object *object);
|
|
void moveObject(Object *object, ThreadData *currentData,
|
|
ThreadData *targetData);
|
|
|
|
std::thread thread_;
|
|
ThreadData *data_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|
|
|
|
#endif /* __LIBCAMERA_BASE_THREAD_H__ */
|