3335d5a504
Many signals used in internal and public APIs carry the emitter pointer as a signal argument. This was done to allow slots connected to multiple signal instances to differentiate between emitters. While starting from a good intention of facilitating the implementation of slots, it turned out to be a bad API design as the signal isn't meant to know what it will be connected to, and thus shouldn't carry parameters that are solely meant to support a use case specific to the connected slot. These pointers turn out to be unused in all slots but one. In the only case where it is needed, it can be obtained by wrapping the slot in a lambda function when connecting the signal. Do so, and drop the emitter pointer from all signals. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
106 lines
1.8 KiB
C++
106 lines
1.8 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* timer-thread.cpp - Threaded timer test
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <iostream>
|
|
|
|
#include <libcamera/base/event_dispatcher.h>
|
|
#include <libcamera/base/thread.h>
|
|
#include <libcamera/base/timer.h>
|
|
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class TimeoutHandler : public Object
|
|
{
|
|
public:
|
|
TimeoutHandler()
|
|
: timer_(this), timeout_(false)
|
|
{
|
|
timer_.timeout.connect(this, &TimeoutHandler::timeoutHandler);
|
|
timer_.start(100);
|
|
}
|
|
|
|
void restart()
|
|
{
|
|
timeout_ = false;
|
|
timer_.start(100);
|
|
}
|
|
|
|
bool timeout() const
|
|
{
|
|
return timeout_;
|
|
}
|
|
|
|
private:
|
|
void timeoutHandler()
|
|
{
|
|
timeout_ = true;
|
|
}
|
|
|
|
Timer timer_;
|
|
bool timeout_;
|
|
};
|
|
|
|
class TimerThreadTest : public Test
|
|
{
|
|
protected:
|
|
int init()
|
|
{
|
|
thread_.start();
|
|
timeout_.moveToThread(&thread_);
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run()
|
|
{
|
|
/*
|
|
* Test that the timer expires and emits the timeout signal in
|
|
* the thread it belongs to.
|
|
*/
|
|
this_thread::sleep_for(chrono::milliseconds(200));
|
|
|
|
if (!timeout_.timeout()) {
|
|
cout << "Timer expiration test failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that starting the timer from another thread fails. We
|
|
* need to interrupt the event dispatcher to make sure we don't
|
|
* succeed simply because the event dispatcher hasn't noticed
|
|
* the timer restart.
|
|
*/
|
|
timeout_.restart();
|
|
thread_.eventDispatcher()->interrupt();
|
|
|
|
this_thread::sleep_for(chrono::milliseconds(200));
|
|
|
|
if (timeout_.timeout()) {
|
|
cout << "Timer restart test failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
/* Must stop thread before destroying timeout. */
|
|
thread_.exit(0);
|
|
thread_.wait();
|
|
}
|
|
|
|
private:
|
|
TimeoutHandler timeout_;
|
|
Thread thread_;
|
|
};
|
|
|
|
TEST_REGISTER(TimerThreadTest)
|