343978af0b
The V4L2Device class uses V4L2ControlList as a controls container for the getControls() and setControls() operations. Having a distinct container from ControlList will makes the IPA API more complex, as it needs to explicitly transport both types of lists. This will become even more painful when implementing serialisation and deserialisation. To simplify the IPA API and ease the implementation of serialisation and deserialisation, replace usage of V4L2ControlList with ControlList in the V4L2Device (and thus CameraSensor) API. The V4L2ControlList class becomes a thin wrapper around ControlList that slightly simplifies the creation of control lists for V4L2 controls, and may be removed in the future. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Tested-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
100 lines
2.7 KiB
C++
100 lines
2.7 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* controls.cpp - V4L2 device controls handling test
|
|
*/
|
|
|
|
#include <climits>
|
|
#include <iostream>
|
|
|
|
#include "v4l2_videodevice.h"
|
|
|
|
#include "v4l2_videodevice_test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class V4L2ControlTest : public V4L2VideoDeviceTest
|
|
{
|
|
public:
|
|
V4L2ControlTest()
|
|
: V4L2VideoDeviceTest("vivid", "vivid-000-vid-cap")
|
|
{
|
|
}
|
|
|
|
protected:
|
|
int run()
|
|
{
|
|
const V4L2ControlInfoMap &info = capture_->controls();
|
|
|
|
/* Test control enumeration. */
|
|
if (info.empty()) {
|
|
cerr << "Failed to enumerate controls" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (info.find(V4L2_CID_BRIGHTNESS) == info.end() ||
|
|
info.find(V4L2_CID_CONTRAST) == info.end() ||
|
|
info.find(V4L2_CID_SATURATION) == info.end()) {
|
|
cerr << "Missing controls" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
const V4L2ControlInfo &brightness = info.find(V4L2_CID_BRIGHTNESS)->second;
|
|
const V4L2ControlInfo &contrast = info.find(V4L2_CID_CONTRAST)->second;
|
|
const V4L2ControlInfo &saturation = info.find(V4L2_CID_SATURATION)->second;
|
|
|
|
/* Test getting controls. */
|
|
V4L2ControlList ctrls(info);
|
|
ctrls.set(V4L2_CID_BRIGHTNESS, -1);
|
|
ctrls.set(V4L2_CID_CONTRAST, -1);
|
|
ctrls.set(V4L2_CID_SATURATION, -1);
|
|
|
|
int ret = capture_->getControls(&ctrls);
|
|
if (ret) {
|
|
cerr << "Failed to get controls" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (ctrls.get(V4L2_CID_BRIGHTNESS).get<int32_t>() == -1 ||
|
|
ctrls.get(V4L2_CID_CONTRAST).get<int32_t>() == -1 ||
|
|
ctrls.get(V4L2_CID_SATURATION).get<int32_t>() == -1) {
|
|
cerr << "Incorrect value for retrieved controls" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test setting controls. */
|
|
ctrls.set(V4L2_CID_BRIGHTNESS, brightness.range().min());
|
|
ctrls.set(V4L2_CID_CONTRAST, contrast.range().max());
|
|
ctrls.set(V4L2_CID_SATURATION, saturation.range().min());
|
|
|
|
ret = capture_->setControls(&ctrls);
|
|
if (ret) {
|
|
cerr << "Failed to set controls" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test setting controls outside of range. */
|
|
ctrls.set(V4L2_CID_BRIGHTNESS, brightness.range().min().get<int32_t>() - 1);
|
|
ctrls.set(V4L2_CID_CONTRAST, contrast.range().max().get<int32_t>() + 1);
|
|
ctrls.set(V4L2_CID_SATURATION, saturation.range().min().get<int32_t>() + 1);
|
|
|
|
ret = capture_->setControls(&ctrls);
|
|
if (ret) {
|
|
cerr << "Failed to set controls (out of range)" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (ctrls.get(V4L2_CID_BRIGHTNESS) != brightness.range().min() ||
|
|
ctrls.get(V4L2_CID_CONTRAST) != brightness.range().max() ||
|
|
ctrls.get(V4L2_CID_SATURATION) != saturation.range().min().get<int32_t>() + 1) {
|
|
cerr << "Controls not updated when set" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
};
|
|
|
|
TEST_REGISTER(V4L2ControlTest);
|