libcamera/test/libtest
Laurent Pinchart 395d43d6d7 libcamera: v4l2_videodevice: Drop toV4L2PixelFormat()
The V4L2VideoDevice::toV4L2PixelFormat() function is incorrectly
implemented, as it will pick a multi-planar format if the device
supports the multi-planar API, even if only single-planar formats are
supported. This currently works because the implementation calls
V4L2PixelFormat::fromPixelFormat(), which ignores the multiplanar
argument and always returns a single-planar format.

Fixing this isn't trivial. As we don't need to support multi-planar V4L2
formats at this point, drop the function instead of pretending
everything is fine, and call V4L2PixelFormat::fromPixelFormat() directly
from pipeline handlers. As the single-planar case is the most common,
set the multiplanar argument to false by default to avoid long lines.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
2021-09-07 19:17:46 +03:00
..
buffer_source.cpp libcamera: v4l2_videodevice: Drop toV4L2PixelFormat() 2021-09-07 19:17:46 +03:00
buffer_source.h test: Include specific headers instead of libcamera.h 2020-09-21 13:50:42 +03:00
camera_test.cpp libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION 2021-08-19 12:54:03 +05:30
camera_test.h libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION 2021-08-19 12:54:03 +05:30
meson.build libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
test.cpp tests: remove IPA_PROXY_PATH environment variable 2020-03-18 16:17:56 +00:00
test.h meson: Remove -Wno-unused-parameter 2020-08-25 02:58:04 +03:00