626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
137 lines
2.3 KiB
C++
137 lines
2.3 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* Threaded event test
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <iostream>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
|
|
#include <libcamera/base/event_notifier.h>
|
|
#include <libcamera/base/object.h>
|
|
#include <libcamera/base/thread.h>
|
|
#include <libcamera/base/timer.h>
|
|
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class EventHandler : public Object
|
|
{
|
|
public:
|
|
EventHandler()
|
|
: notified_(false)
|
|
{
|
|
int ret = pipe(pipefd_);
|
|
if (ret < 0) {
|
|
ret = errno;
|
|
cout << "pipe() failed: " << strerror(ret) << endl;
|
|
}
|
|
|
|
notifier_ = new EventNotifier(pipefd_[0], EventNotifier::Read, this);
|
|
notifier_->activated.connect(this, &EventHandler::readReady);
|
|
}
|
|
|
|
~EventHandler()
|
|
{
|
|
delete notifier_;
|
|
|
|
close(pipefd_[0]);
|
|
close(pipefd_[1]);
|
|
}
|
|
|
|
int notify()
|
|
{
|
|
std::string data("H2G2");
|
|
ssize_t ret;
|
|
|
|
memset(data_, 0, sizeof(data_));
|
|
size_ = 0;
|
|
|
|
ret = write(pipefd_[1], data.data(), data.size());
|
|
if (ret < 0) {
|
|
cout << "Pipe write failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
bool notified() const
|
|
{
|
|
return notified_;
|
|
}
|
|
|
|
private:
|
|
void readReady()
|
|
{
|
|
size_ = read(notifier_->fd(), data_, sizeof(data_));
|
|
notified_ = true;
|
|
}
|
|
|
|
EventNotifier *notifier_;
|
|
|
|
int pipefd_[2];
|
|
|
|
bool notified_;
|
|
char data_[16];
|
|
ssize_t size_;
|
|
};
|
|
|
|
class EventThreadTest : public Test
|
|
{
|
|
protected:
|
|
int init()
|
|
{
|
|
thread_.start();
|
|
|
|
handler_ = new EventHandler();
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run()
|
|
{
|
|
|
|
/*
|
|
* Fire the event notifier and then move the notifier to a
|
|
* different thread. The notifier will not notice the event
|
|
* immediately as there is no event dispatcher loop running in
|
|
* the main thread. This tests that a notifier being moved to a
|
|
* different thread will correctly process already pending
|
|
* events in the new thread.
|
|
*/
|
|
handler_->notify();
|
|
handler_->moveToThread(&thread_);
|
|
|
|
this_thread::sleep_for(chrono::milliseconds(100));
|
|
|
|
if (!handler_->notified()) {
|
|
cout << "Thread event handling test failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
/*
|
|
* Object class instances must be destroyed from the thread
|
|
* they live in.
|
|
*/
|
|
handler_->deleteLater();
|
|
thread_.exit(0);
|
|
thread_.wait();
|
|
}
|
|
|
|
private:
|
|
EventHandler *handler_;
|
|
Thread thread_;
|
|
};
|
|
|
|
TEST_REGISTER(EventThreadTest)
|