626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
77 lines
2.6 KiB
Python
Executable file
77 lines
2.6 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
# Copyright (C) 2020, Google Inc.
|
|
#
|
|
# Author: Paul Elder <paul.elder@ideasonboard.com>
|
|
#
|
|
# Example of how to extract information from libcamera lttng traces
|
|
|
|
import argparse
|
|
import bt2
|
|
import statistics as stats
|
|
import sys
|
|
|
|
# pipeline -> {function -> stack(timestamps)}
|
|
timestamps = {}
|
|
|
|
# pipeline:function -> samples[]
|
|
samples = {}
|
|
|
|
def main(argv):
|
|
parser = argparse.ArgumentParser(
|
|
description='A simple analysis script to get statistics on time taken for IPA calls')
|
|
parser.add_argument('-p', '--pipeline', type=str,
|
|
help='Name of pipeline to filter for')
|
|
parser.add_argument('trace_path', type=str,
|
|
help='Path to lttng trace (eg. ~/lttng-traces/demo-20201029-184003)')
|
|
args = parser.parse_args(argv[1:])
|
|
|
|
traces = bt2.TraceCollectionMessageIterator(args.trace_path)
|
|
for msg in traces:
|
|
if type(msg) is not bt2._EventMessageConst or \
|
|
'pipeline_name' not in msg.event.payload_field or \
|
|
(args.pipeline is not None and \
|
|
msg.event.payload_field['pipeline_name'] != args.pipeline):
|
|
continue
|
|
|
|
pipeline = msg.event.payload_field['pipeline_name']
|
|
event = msg.event.name
|
|
func = msg.event.payload_field['function_name']
|
|
timestamp_ns = msg.default_clock_snapshot.ns_from_origin
|
|
|
|
if event == 'libcamera:ipa_call_begin':
|
|
if pipeline not in timestamps:
|
|
timestamps[pipeline] = {}
|
|
if func not in timestamps[pipeline]:
|
|
timestamps[pipeline][func] = []
|
|
timestamps[pipeline][func].append(timestamp_ns)
|
|
|
|
if event == 'libcamera:ipa_call_end':
|
|
ts = timestamps[pipeline][func].pop()
|
|
key = f'{pipeline}:{func}'
|
|
if key not in samples:
|
|
samples[key] = []
|
|
samples[key].append(timestamp_ns - ts)
|
|
|
|
# Compute stats
|
|
rows = []
|
|
rows.append(['pipeline:function', 'min', 'max', 'mean', 'stddev'])
|
|
for k, v in samples.items():
|
|
mean = int(stats.mean(v))
|
|
stddev = int(stats.stdev(v))
|
|
minv = min(v)
|
|
maxv = max(v)
|
|
rows.append([k, str(minv), str(maxv), str(mean), str(stddev)])
|
|
|
|
# Get maximum string width for every column
|
|
widths = []
|
|
for i in range(len(rows[0])):
|
|
widths.append(max([len(row[i]) for row in rows]))
|
|
|
|
# Print stats table
|
|
for row in rows:
|
|
fmt = [row[i].rjust(widths[i]) for i in range(1, 5)]
|
|
print('{} {} {} {} {}'.format(row[0].ljust(widths[0]), *fmt))
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main(sys.argv))
|