If any ipa_context instances are destroyed after the IPAManager is destroyed, then a segfault will occur, since the modules have been unloaded by the IPAManager and the context function pointers have been freed. Fix this by making the lifetime of the IPAManager explicit, and make the CameraManager construct and deconstruct (automatically, via a unique pointer) the IPAManager. Also update the IPA interface test to do the construction and deconstruction of the IPAManager, as it does not use the CameraManager. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
174 lines
4 KiB
C++
174 lines
4 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* ipa_interface_test.cpp - Test the IPA interface
|
|
*/
|
|
|
|
#include <fcntl.h>
|
|
#include <iostream>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include <libcamera/event_dispatcher.h>
|
|
#include <libcamera/event_notifier.h>
|
|
#include <libcamera/ipa/ipa_vimc.h>
|
|
#include <libcamera/timer.h>
|
|
|
|
#include "libcamera/internal/device_enumerator.h"
|
|
#include "libcamera/internal/ipa_manager.h"
|
|
#include "libcamera/internal/ipa_module.h"
|
|
#include "libcamera/internal/pipeline_handler.h"
|
|
#include "libcamera/internal/thread.h"
|
|
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class IPAInterfaceTest : public Test, public Object
|
|
{
|
|
public:
|
|
IPAInterfaceTest()
|
|
: trace_(IPAOperationNone), notifier_(nullptr), fd_(-1)
|
|
{
|
|
}
|
|
|
|
~IPAInterfaceTest()
|
|
{
|
|
delete notifier_;
|
|
ipa_.reset();
|
|
ipaManager_.reset();
|
|
}
|
|
|
|
protected:
|
|
int init() override
|
|
{
|
|
ipaManager_ = make_unique<IPAManager>();
|
|
|
|
/* Create a pipeline handler for vimc. */
|
|
std::vector<PipelineHandlerFactory *> &factories =
|
|
PipelineHandlerFactory::factories();
|
|
for (PipelineHandlerFactory *factory : factories) {
|
|
if (factory->name() == "PipelineHandlerVimc") {
|
|
pipe_ = factory->create(nullptr);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!pipe_) {
|
|
cerr << "Vimc pipeline not found" << endl;
|
|
return TestPass;
|
|
}
|
|
|
|
/* Create and open the communication FIFO. */
|
|
int ret = mkfifo(VIMC_IPA_FIFO_PATH, S_IRUSR | S_IWUSR);
|
|
if (ret) {
|
|
ret = errno;
|
|
cerr << "Failed to create IPA test FIFO at '"
|
|
<< VIMC_IPA_FIFO_PATH << "': " << strerror(ret)
|
|
<< endl;
|
|
return TestFail;
|
|
}
|
|
|
|
ret = open(VIMC_IPA_FIFO_PATH, O_RDONLY | O_NONBLOCK);
|
|
if (ret < 0) {
|
|
ret = errno;
|
|
cerr << "Failed to open IPA test FIFO at '"
|
|
<< VIMC_IPA_FIFO_PATH << "': " << strerror(ret)
|
|
<< endl;
|
|
unlink(VIMC_IPA_FIFO_PATH);
|
|
return TestFail;
|
|
}
|
|
fd_ = ret;
|
|
|
|
notifier_ = new EventNotifier(fd_, EventNotifier::Read, this);
|
|
notifier_->activated.connect(this, &IPAInterfaceTest::readTrace);
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run() override
|
|
{
|
|
EventDispatcher *dispatcher = thread()->eventDispatcher();
|
|
Timer timer;
|
|
|
|
ipa_ = IPAManager::instance()->createIPA(pipe_.get(), 0, 0);
|
|
if (!ipa_) {
|
|
cerr << "Failed to create VIMC IPA interface" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test initialization of IPA module. */
|
|
std::string conf = ipa_->configurationFile("vimc.conf");
|
|
int ret = ipa_->init(IPASettings{ conf });
|
|
if (ret < 0) {
|
|
cerr << "IPA interface init() failed" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
timer.start(1000);
|
|
while (timer.isRunning() && trace_ != IPAOperationInit)
|
|
dispatcher->processEvents();
|
|
|
|
if (trace_ != IPAOperationInit) {
|
|
cerr << "Failed to test IPA initialization sequence"
|
|
<< endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test start of IPA module. */
|
|
ipa_->start();
|
|
timer.start(1000);
|
|
while (timer.isRunning() && trace_ != IPAOperationStart)
|
|
dispatcher->processEvents();
|
|
|
|
if (trace_ != IPAOperationStart) {
|
|
cerr << "Failed to test IPA start sequence" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test stop of IPA module. */
|
|
ipa_->stop();
|
|
timer.start(1000);
|
|
while (timer.isRunning() && trace_ != IPAOperationStop)
|
|
dispatcher->processEvents();
|
|
|
|
if (trace_ != IPAOperationStop) {
|
|
cerr << "Failed to test IPA stop sequence" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup() override
|
|
{
|
|
close(fd_);
|
|
unlink(VIMC_IPA_FIFO_PATH);
|
|
}
|
|
|
|
private:
|
|
void readTrace(EventNotifier *notifier)
|
|
{
|
|
ssize_t s = read(notifier->fd(), &trace_, sizeof(trace_));
|
|
if (s < 0) {
|
|
int ret = errno;
|
|
cerr << "Failed to read from IPA test FIFO at '"
|
|
<< VIMC_IPA_FIFO_PATH << "': " << strerror(ret)
|
|
<< endl;
|
|
trace_ = IPAOperationNone;
|
|
}
|
|
}
|
|
|
|
std::shared_ptr<PipelineHandler> pipe_;
|
|
std::unique_ptr<IPAProxy> ipa_;
|
|
std::unique_ptr<IPAManager> ipaManager_;
|
|
enum IPAOperationCode trace_;
|
|
EventNotifier *notifier_;
|
|
int fd_;
|
|
};
|
|
|
|
TEST_REGISTER(IPAInterfaceTest)
|