339e9b2d97
Three tests {capture,configuration_set,statemachine} override the
CameraTest::init() function, and call it as the first action.
However they were not checking the return value, and each of the tests
will segfault if the VIMC camera is not obtained.
Check the return value of the CameraTest base class initialisation and
return any errors to the test suite if initialisation fails.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
100 lines
2.1 KiB
C++
100 lines
2.1 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* libcamera Camera API tests
|
|
*/
|
|
|
|
#include <iostream>
|
|
|
|
#include "camera_test.h"
|
|
|
|
using namespace std;
|
|
|
|
namespace {
|
|
|
|
class ConfigurationSet : public CameraTest
|
|
{
|
|
protected:
|
|
int init() override
|
|
{
|
|
int ret = CameraTest::init();
|
|
if (ret)
|
|
return ret;
|
|
|
|
config_ = camera_->generateConfiguration({ StreamRole::VideoRecording });
|
|
if (!config_ || config_->size() != 1) {
|
|
cout << "Failed to generate default configuration" << endl;
|
|
CameraTest::cleanup();
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run() override
|
|
{
|
|
StreamConfiguration &cfg = config_->at(0);
|
|
|
|
if (camera_->acquire()) {
|
|
cout << "Failed to acquire the camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test that setting the default configuration works. */
|
|
if (camera_->configure(config_.get())) {
|
|
cout << "Failed to set default configuration" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that configuring the camera fails if it is not
|
|
* acquired, this will also test release and reacquiring
|
|
* of the camera.
|
|
*/
|
|
if (camera_->release()) {
|
|
cout << "Failed to release the camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (!camera_->configure(config_.get())) {
|
|
cout << "Setting configuration on a camera not acquired succeeded when it should have failed"
|
|
<< endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (camera_->acquire()) {
|
|
cout << "Failed to acquire the camera" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that modifying the default configuration works. Doubling
|
|
* the default configuration of the VIMC camera is known to
|
|
* work.
|
|
*/
|
|
cfg.size.width *= 2;
|
|
cfg.size.height *= 2;
|
|
if (camera_->configure(config_.get())) {
|
|
cout << "Failed to set modified configuration" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that setting an invalid configuration fails.
|
|
*/
|
|
cfg.size = { 0, 0 };
|
|
if (!camera_->configure(config_.get())) {
|
|
cout << "Invalid configuration incorrectly accepted" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
std::unique_ptr<CameraConfiguration> config_;
|
|
};
|
|
|
|
} /* namespace */
|
|
|
|
TEST_REGISTER(ConfigurationSet);
|