53704ac3f4
The CameraManager class is not supposed to be instantiated multiple times, which led to a singleton implementation. This requires a global instance of the CameraManager, which is destroyed when the global destructors are executed. Relying on global instances causes issues with cleanup, as the order in which the global destructors are run can't be controlled. In particular, the Android camera HAL implementation ends up destroying the CameraHalManager after the CameraManager, which leads to use-after-free problems. To solve this, remove the CameraManager::instance() method and make the CameraManager class instantiable directly. Multiple instances are still not allowed, and this is enforced by storing the instance pointer internally to be checked when an instance is created. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
126 lines
2.7 KiB
C++
126 lines
2.7 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* ipu3_pipeline_test.cpp - Intel IPU3 pipeline test
|
|
*/
|
|
|
|
#include <iostream>
|
|
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include <libcamera/camera.h>
|
|
#include <libcamera/camera_manager.h>
|
|
|
|
#include "device_enumerator.h"
|
|
#include "media_device.h"
|
|
#include "media_object.h"
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
/*
|
|
* Verify that the Intel IPU3 pipeline handler gets matched and cameras
|
|
* are enumerated correctly.
|
|
*
|
|
* The test is supposed to be run on an IPU3 platform, otherwise it gets
|
|
* skipped.
|
|
*
|
|
* The test lists all cameras registered in the system, if any camera is
|
|
* available at all.
|
|
*/
|
|
class IPU3PipelineTest : public Test
|
|
{
|
|
protected:
|
|
int init();
|
|
int run();
|
|
void cleanup();
|
|
|
|
private:
|
|
CameraManager *cameraManager_;
|
|
unsigned int sensors_;
|
|
};
|
|
|
|
int IPU3PipelineTest::init()
|
|
{
|
|
unique_ptr<DeviceEnumerator> enumerator = DeviceEnumerator::create();
|
|
if (!enumerator) {
|
|
cerr << "Failed to create device enumerator" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (enumerator->enumerate()) {
|
|
cerr << "Failed to enumerate media devices" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
DeviceMatch imgu_dm("ipu3-imgu");
|
|
DeviceMatch cio2_dm("ipu3-cio2");
|
|
|
|
if (!enumerator->search(imgu_dm)) {
|
|
cerr << "Failed to find IPU3 IMGU: test skip" << endl;
|
|
return TestSkip;
|
|
}
|
|
|
|
std::shared_ptr<MediaDevice> cio2 = enumerator->search(cio2_dm);
|
|
if (!cio2) {
|
|
cerr << "Failed to find IPU3 CIO2: test skip" << endl;
|
|
return TestSkip;
|
|
}
|
|
|
|
/*
|
|
* Camera sensor are connected to the CIO2 unit.
|
|
* Count how many sensors are connected in the system
|
|
* and later verify this matches the number of registered
|
|
* cameras.
|
|
*/
|
|
int ret = cio2->populate();
|
|
if (ret) {
|
|
cerr << "Failed to populate media device " << cio2->deviceNode() << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
sensors_ = 0;
|
|
const vector<MediaEntity *> &entities = cio2->entities();
|
|
for (MediaEntity *entity : entities) {
|
|
if (entity->function() == MEDIA_ENT_F_CAM_SENSOR)
|
|
sensors_++;
|
|
}
|
|
|
|
enumerator.reset(nullptr);
|
|
|
|
cameraManager_ = new CameraManager();
|
|
ret = cameraManager_->start();
|
|
if (ret) {
|
|
cerr << "Failed to start the CameraManager" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int IPU3PipelineTest::run()
|
|
{
|
|
auto cameras = cameraManager_->cameras();
|
|
for (const std::shared_ptr<Camera> &cam : cameras)
|
|
cout << "Found camera '" << cam->name() << "'" << endl;
|
|
|
|
if (cameras.size() != sensors_) {
|
|
cerr << cameras.size() << " cameras registered, but " << sensors_
|
|
<< " were expected" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void IPU3PipelineTest::cleanup()
|
|
{
|
|
cameraManager_->stop();
|
|
delete cameraManager_;
|
|
}
|
|
|
|
TEST_REGISTER(IPU3PipelineTest)
|