libcamera/test/object-invoke.cpp
Laurent Pinchart 626172a16b libcamera: Drop file name from header comment blocks
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.

Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.

The change was generated with the following script:

----------------------------------------

dirs="include/libcamera src test utils"

declare -rA patterns=(
	['c']=' \* '
	['cpp']=' \* '
	['h']=' \* '
	['py']='# '
	['sh']='# '
)

for ext in ${!patterns[@]} ; do
	files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
	pattern=${patterns[${ext}]}

	for file in $files ; do
		name=$(basename ${file})
		sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
	done
done
----------------------------------------

This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
2024-05-08 22:39:50 +03:00

203 lines
4.3 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* Cross-thread Object method invocation test
*/
#include <iostream>
#include <thread>
#include <libcamera/base/event_dispatcher.h>
#include <libcamera/base/object.h>
#include <libcamera/base/thread.h>
#include "test.h"
using namespace std;
using namespace libcamera;
class InvokedObject : public Object
{
public:
enum Status {
NoCall,
InvalidThread,
CallReceived,
};
InvokedObject()
: status_(NoCall)
{
}
Status status() const { return status_; }
int value() const { return value_; }
void reset()
{
status_ = NoCall;
value_ = 0;
}
void method(int value)
{
if (Thread::current() != thread())
status_ = InvalidThread;
else
status_ = CallReceived;
value_ = value;
}
void methodWithReference([[maybe_unused]] const int &value)
{
}
int methodWithReturn()
{
return 42;
}
private:
Status status_;
int value_;
};
class ObjectInvokeTest : public Test
{
protected:
int run()
{
EventDispatcher *dispatcher = Thread::current()->eventDispatcher();
/*
* Test that queued method invocation in the same thread goes
* through the event dispatcher.
*/
object_.invokeMethod(&InvokedObject::method,
ConnectionTypeQueued, 42);
if (object_.status() != InvokedObject::NoCall) {
cerr << "Method not invoked asynchronously" << endl;
return TestFail;
}
dispatcher->processEvents();
switch (object_.status()) {
case InvokedObject::NoCall:
cout << "Method not invoked for main thread" << endl;
return TestFail;
case InvokedObject::InvalidThread:
cout << "Method invoked in incorrect thread for main thread" << endl;
return TestFail;
default:
break;
}
if (object_.value() != 42) {
cout << "Method invoked with incorrect value for main thread" << endl;
return TestFail;
}
/*
* Test that blocking invocation is delivered directly when the
* caller and callee live in the same thread.
*/
object_.reset();
object_.invokeMethod(&InvokedObject::method,
ConnectionTypeBlocking, 42);
switch (object_.status()) {
case InvokedObject::NoCall:
cout << "Method not invoked for main thread (blocking)" << endl;
return TestFail;
case InvokedObject::InvalidThread:
cout << "Method invoked in incorrect thread for main thread (blocking)" << endl;
return TestFail;
default:
break;
}
/*
* Move the object to a thread and verify that auto method
* invocation is delivered in the correct thread.
*/
object_.reset();
object_.moveToThread(&thread_);
thread_.start();
object_.invokeMethod(&InvokedObject::method,
ConnectionTypeBlocking, 42);
switch (object_.status()) {
case InvokedObject::NoCall:
cout << "Method not invoked for custom thread" << endl;
return TestFail;
case InvokedObject::InvalidThread:
cout << "Method invoked in incorrect thread for custom thread" << endl;
return TestFail;
default:
break;
}
if (object_.value() != 42) {
cout << "Method invoked with incorrect value for custom thread" << endl;
return TestFail;
}
/* Test that direct method invocation bypasses threads. */
object_.reset();
object_.invokeMethod(&InvokedObject::method,
ConnectionTypeDirect, 42);
switch (object_.status()) {
case InvokedObject::NoCall:
cout << "Method not invoked for custom thread" << endl;
return TestFail;
case InvokedObject::CallReceived:
cout << "Method invoked in incorrect thread for direct call" << endl;
return TestFail;
default:
break;
}
if (object_.value() != 42) {
cout << "Method invoked with incorrect value for direct call" << endl;
return TestFail;
}
/*
* Test invoking a method that takes reference arguments. This
* targets compilation, there's no need to check runtime
* results.
*/
object_.invokeMethod(&InvokedObject::methodWithReference,
ConnectionTypeBlocking, 42);
/* Test invoking a method that returns a value. */
int ret = object_.invokeMethod(&InvokedObject::methodWithReturn,
ConnectionTypeBlocking);
if (ret != 42) {
cout << "Method invoked return incorrect value (" << ret
<< ")" << endl;
return TestFail;
}
return TestPass;
}
void cleanup()
{
thread_.exit(0);
thread_.wait();
}
private:
Thread thread_;
InvokedObject object_;
};
TEST_REGISTER(ObjectInvokeTest)