560ceb1ea8
Commite297673e76("libcamera: v4l2_device: Adjust colorspace based on pixel format") has introduced a warning when trying to convert a color space from V4L2 to libcamera if the media bus code is unknown. This was meant to catch unknown image formats, but turned out to be also triggered for metadata formats. Color spaces are not applicable to metadata formats, there should thus be no warning. Fix it by skipping the color space translation and returning std::nullopt directly if the kernel reports V4L2_COLORSPACE_DEFAULT. This doesn't introduce any change in behaviour other than getting rid of the warning, as the V4L2Device::toColorSpace() function returns std::nullopt already in that case. Fixes:e297673e76("libcamera: v4l2_device: Adjust colorspace based on pixel format") Reported-by: Naushir Patuck <naush@raspberrypi.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Tested-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
117 lines
2.7 KiB
C++
117 lines
2.7 KiB
C++
/* SPDX-License-Identifier: LGPL-2.1-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* v4l2_subdevice.h - V4L2 Subdevice
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <ostream>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include <linux/v4l2-subdev.h>
|
|
|
|
#include <libcamera/base/class.h>
|
|
#include <libcamera/base/log.h>
|
|
|
|
#include <libcamera/color_space.h>
|
|
#include <libcamera/geometry.h>
|
|
|
|
#include "libcamera/internal/formats.h"
|
|
#include "libcamera/internal/media_object.h"
|
|
#include "libcamera/internal/v4l2_device.h"
|
|
|
|
namespace libcamera {
|
|
|
|
class MediaDevice;
|
|
|
|
struct V4L2SubdeviceCapability final : v4l2_subdev_capability {
|
|
bool isReadOnly() const
|
|
{
|
|
return capabilities & V4L2_SUBDEV_CAP_RO_SUBDEV;
|
|
}
|
|
bool hasStreams() const
|
|
{
|
|
return capabilities & V4L2_SUBDEV_CAP_MPLEXED;
|
|
}
|
|
};
|
|
|
|
struct V4L2SubdeviceFormat {
|
|
uint32_t mbus_code;
|
|
Size size;
|
|
std::optional<ColorSpace> colorSpace;
|
|
|
|
const std::string toString() const;
|
|
uint8_t bitsPerPixel() const;
|
|
};
|
|
|
|
std::ostream &operator<<(std::ostream &out, const V4L2SubdeviceFormat &f);
|
|
|
|
class V4L2Subdevice : public V4L2Device
|
|
{
|
|
public:
|
|
using Formats = std::map<unsigned int, std::vector<SizeRange>>;
|
|
|
|
enum Whence {
|
|
TryFormat = V4L2_SUBDEV_FORMAT_TRY,
|
|
ActiveFormat = V4L2_SUBDEV_FORMAT_ACTIVE,
|
|
};
|
|
|
|
class Routing : public std::vector<struct v4l2_subdev_route>
|
|
{
|
|
public:
|
|
std::string toString() const;
|
|
};
|
|
|
|
explicit V4L2Subdevice(const MediaEntity *entity);
|
|
~V4L2Subdevice();
|
|
|
|
int open();
|
|
|
|
const MediaEntity *entity() const { return entity_; }
|
|
|
|
int getSelection(unsigned int pad, unsigned int target,
|
|
Rectangle *rect);
|
|
int setSelection(unsigned int pad, unsigned int target,
|
|
Rectangle *rect);
|
|
|
|
Formats formats(unsigned int pad);
|
|
|
|
int getFormat(unsigned int pad, V4L2SubdeviceFormat *format,
|
|
Whence whence = ActiveFormat);
|
|
int setFormat(unsigned int pad, V4L2SubdeviceFormat *format,
|
|
Whence whence = ActiveFormat);
|
|
|
|
int getRouting(Routing *routing, Whence whence = ActiveFormat);
|
|
int setRouting(Routing *routing, Whence whence = ActiveFormat);
|
|
|
|
const std::string &model();
|
|
const V4L2SubdeviceCapability &caps() const { return caps_; }
|
|
|
|
static std::unique_ptr<V4L2Subdevice>
|
|
fromEntityName(const MediaDevice *media, const std::string &entity);
|
|
|
|
protected:
|
|
std::string logPrefix() const override;
|
|
|
|
private:
|
|
LIBCAMERA_DISABLE_COPY(V4L2Subdevice)
|
|
|
|
std::optional<ColorSpace>
|
|
toColorSpace(const v4l2_mbus_framefmt &format) const;
|
|
|
|
std::vector<unsigned int> enumPadCodes(unsigned int pad);
|
|
std::vector<SizeRange> enumPadSizes(unsigned int pad,
|
|
unsigned int code);
|
|
|
|
const MediaEntity *entity_;
|
|
|
|
std::string model_;
|
|
struct V4L2SubdeviceCapability caps_;
|
|
};
|
|
|
|
} /* namespace libcamera */
|