626172a16b
Source files in libcamera start by a comment block header, which
includes the file name and a one-line description of the file contents.
While the latter is useful to get a quick overview of the file contents
at a glance, the former is mostly a source of inconvenience. The name in
the comments can easily get out of sync with the file name when files
are renamed, and copy & paste during development have often lead to
incorrect names being used to start with.
Readers of the source code are expected to know which file they're
looking it. Drop the file name from the header comment block.
The change was generated with the following script:
----------------------------------------
dirs="include/libcamera src test utils"
declare -rA patterns=(
['c']=' \* '
['cpp']=' \* '
['h']=' \* '
['py']='# '
['sh']='# '
)
for ext in ${!patterns[@]} ; do
files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done)
pattern=${patterns[${ext}]}
for file in $files ; do
name=$(basename ${file})
sed -i "s/^\(${pattern}\)${name} - /\1/" "$file"
done
done
----------------------------------------
This misses several files that are out of sync with the comment block
header. Those will be addressed separately and manually.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
134 lines
2.4 KiB
C++
134 lines
2.4 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* Cross-thread signal delivery test
|
|
*/
|
|
|
|
#include <chrono>
|
|
#include <iostream>
|
|
#include <thread>
|
|
|
|
#include <libcamera/base/message.h>
|
|
#include <libcamera/base/object.h>
|
|
#include <libcamera/base/thread.h>
|
|
#include <libcamera/base/utils.h>
|
|
|
|
#include "test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class SignalReceiver : public Object
|
|
{
|
|
public:
|
|
enum Status {
|
|
NoSignal,
|
|
InvalidThread,
|
|
SignalReceived,
|
|
};
|
|
|
|
SignalReceiver()
|
|
: status_(NoSignal)
|
|
{
|
|
}
|
|
|
|
Status status() const { return status_; }
|
|
int value() const { return value_; }
|
|
void reset()
|
|
{
|
|
status_ = NoSignal;
|
|
value_ = 0;
|
|
}
|
|
|
|
void slot(int value)
|
|
{
|
|
if (Thread::current() != thread())
|
|
status_ = InvalidThread;
|
|
else
|
|
status_ = SignalReceived;
|
|
|
|
value_ = value;
|
|
}
|
|
|
|
private:
|
|
Status status_;
|
|
int value_;
|
|
};
|
|
|
|
class SignalThreadsTest : public Test
|
|
{
|
|
protected:
|
|
int init()
|
|
{
|
|
receiver_ = new SignalReceiver();
|
|
signal_.connect(receiver_, &SignalReceiver::slot);
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run()
|
|
{
|
|
/* Test that a signal is received in the main thread. */
|
|
signal_.emit(0);
|
|
|
|
switch (receiver_->status()) {
|
|
case SignalReceiver::NoSignal:
|
|
cout << "No signal received for direct connection" << endl;
|
|
return TestFail;
|
|
case SignalReceiver::InvalidThread:
|
|
cout << "Signal received in incorrect thread "
|
|
"for direct connection" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* Move the object to a thread and verify that the signal is
|
|
* correctly delivered, with the correct data.
|
|
*/
|
|
receiver_->reset();
|
|
receiver_->moveToThread(&thread_);
|
|
|
|
thread_.start();
|
|
|
|
signal_.emit(42);
|
|
|
|
this_thread::sleep_for(chrono::milliseconds(100));
|
|
|
|
switch (receiver_->status()) {
|
|
case SignalReceiver::NoSignal:
|
|
cout << "No signal received for message connection" << endl;
|
|
return TestFail;
|
|
case SignalReceiver::InvalidThread:
|
|
cout << "Signal received in incorrect thread "
|
|
"for message connection" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
if (receiver_->value() != 42) {
|
|
cout << "Signal received with incorrect value" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
receiver_->deleteLater();
|
|
thread_.exit(0);
|
|
thread_.wait();
|
|
}
|
|
|
|
private:
|
|
SignalReceiver *receiver_;
|
|
Thread thread_;
|
|
|
|
Signal<int> signal_;
|
|
};
|
|
|
|
TEST_REGISTER(SignalThreadsTest)
|