NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions
libcamera/utils
History
Laurent Pinchart 8fffab46b8 utils: checkstyle.py: Add header add checker 
Add a commit checker that ensures that all header files added to the
libcamera includes (public or internal) are accompanied by a
corresponding update of the meson.build file in the same directory.

Here's the output of the new checker when run against a commit that
forgot to update meson.build.

    $ ./utils/checkstyle.py b3383da79f
    ---------------------------------------------------------------------------------
    b3383da79f libcamera: buffer: Create a MappedBuffer
    ---------------------------------------------------------------------------------
    Header include/libcamera/internal/buffer.h added without corresponding update to include/libcamera/internal/meson.build
    ---
    1 potential issue detected, please review

In theory we could extend the checker to cover .cpp files too, but the
issue will be quite noticeable as meson won't build the file if
meson.build isn't updated. Header files are more tricky as problems
would only occur at when installing the headers (for public headers), or
would result in race conditions in the build. Both of those issues are
harder to catch.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
2020-12-29 16:45:35 +02:00
..
hooks utils: hooks: pre-push: Reject commits with a Change-Id 2020-11-02 01:03:31 +02:00
ipc README, meson: Add dependency on ply and jinja2 for IPA interface generation 2020-11-11 19:23:16 +09:00
ipu3 licenses: License all meson files under CC0-1.0 2020-05-13 16:46:24 +03:00
raspberrypi/ctt src: ipa: raspberrypi: Change 'sport' exposure mode name to 'short' 2020-11-20 11:31:56 +00:00
rkisp1 utils: rkisp1: Don't enable immutable link 2020-03-20 01:44:57 +01:00
tracepoints utils: tracepoints: Add simple statistics script 2020-11-03 11:33:41 +09:00
checkstyle.py utils: checkstyle.py: Add header add checker 2020-12-29 16:45:35 +02:00
gen-controls.py utils: gen-controls: Fix enumerators documentation 2020-12-27 12:28:00 +02:00
gen-formats.py libcamera: Move Header generation utilities to utils 2020-09-24 10:55:49 +01:00
gen-header.sh libcamera: Move Header generation utilities to utils 2020-09-24 10:55:49 +01:00
gen-ipa-priv-key.sh libcamera: ipa: Move key generation to utils 2020-09-24 10:56:22 +01:00
gen-ipa-pub-key.py libcamera: ipa: Move key generation to utils 2020-09-24 10:56:22 +01:00
gen-version.sh libcamera: Add build time to version string for dirty builds 2020-08-06 16:20:15 +02:00
meson.build README, meson: Add dependency on ply and jinja2 for IPA interface generation 2020-11-11 19:23:16 +09:00