libcamera/test/pipeline/rkisp1/rkisp1_pipeline_test.cpp
Laurent Pinchart 93e72b695e libcamera: Move internal headers to include/libcamera/internal/
The libcamera internal headers are located in src/libcamera/include/.
The directory is added to the compiler headers search path with a meson
include_directories() directive, and internal headers are included with
(e.g. for the internal semaphore.h header)

  #include "semaphore.h"

All was well, until libcxx decided to implement the C++20
synchronization library. The __threading_support header gained a

  #include <semaphore.h>

to include the pthread's semaphore support. As include_directories()
adds src/libcamera/include/ to the compiler search path with -I, the
internal semaphore.h is included instead of the pthread version.
Needless to say, the compiler isn't happy.

Three options have been considered to fix this issue:

- Use -iquote instead of -I. The -iquote option instructs gcc to only
  consider the header search path for headers included with the ""
  version. Meson unfortunately doesn't support this option.

- Rename the internal semaphore.h header. This was deemed to be the
  beginning of a long whack-a-mole game, where namespace clashes with
  system libraries would appear over time (possibly dependent on
  particular system configurations) and would need to be constantly
  fixed.

- Move the internal headers to another directory to create a unique
  namespace through path components. This causes lots of churn in all
  the existing source files through the all project.

The first option would be best, but isn't available to us due to missing
support in meson. Even if -iquote support was added, we would need to
fix the problem before a new version of meson containing the required
support would be released.

The third option is thus the only practical solution available. Bite the
bullet, and do it, moving headers to include/libcamera/internal/.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
2020-05-16 03:38:11 +03:00

115 lines
2.4 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2020, Linaro
*
* Based on test/pipeline/ipu3/ipu3_pipeline_test.cpp
*
* rkisp1_pipeline_test.cpp - Rockchip RK3399 rkisp1 pipeline test
*/
#include <iostream>
#include <sys/stat.h>
#include <sys/types.h>
#include <unistd.h>
#include <libcamera/camera.h>
#include <libcamera/camera_manager.h>
#include "libcamera/internal/device_enumerator.h"
#include "libcamera/internal/media_device.h"
#include "libcamera/internal/media_object.h"
#include "test.h"
using namespace std;
using namespace libcamera;
/*
* Verify that the RK3399 pipeline handler gets matched and cameras
* are enumerated correctly.
*
* The test is supposed to be run on rockchip platform.
*
* The test lists all cameras registered in the system, if any camera is
* available at all.
*/
class RKISP1PipelineTest : public Test
{
protected:
int init();
int run();
void cleanup();
private:
CameraManager *cameraManager_;
unsigned int sensors_;
};
int RKISP1PipelineTest::init()
{
unique_ptr<DeviceEnumerator> enumerator = DeviceEnumerator::create();
if (!enumerator) {
cerr << "Failed to create device enumerator" << endl;
return TestFail;
}
if (enumerator->enumerate()) {
cerr << "Failed to enumerate media devices" << endl;
return TestFail;
}
DeviceMatch dm("rkisp1");
std::shared_ptr<MediaDevice> rkisp1 = enumerator->search(dm);
if (!rkisp1) {
cerr << "Failed to find rkisp1: test skip" << endl;
return TestSkip;
}
int ret = rkisp1->populate();
if (ret) {
cerr << "Failed to populate media device "
<< rkisp1->deviceNode() << endl;
return TestFail;
}
sensors_ = 0;
const vector<MediaEntity *> &entities = rkisp1->entities();
for (MediaEntity *entity : entities) {
if (entity->function() == MEDIA_ENT_F_CAM_SENSOR)
sensors_++;
}
cameraManager_ = new CameraManager();
ret = cameraManager_->start();
if (ret) {
cerr << "Failed to start the CameraManager" << endl;
return TestFail;
}
return 0;
}
int RKISP1PipelineTest::run()
{
auto cameras = cameraManager_->cameras();
for (const std::shared_ptr<Camera> &cam : cameras)
cout << "Found camera '" << cam->name() << "'" << endl;
if (cameras.size() != sensors_) {
cerr << cameras.size() << " cameras registered, but " << sensors_
<< " were expected" << endl;
return TestFail;
}
return TestPass;
}
void RKISP1PipelineTest::cleanup()
{
cameraManager_->stop();
delete cameraManager_;
}
TEST_REGISTER(RKISP1PipelineTest)