93e72b695e
The libcamera internal headers are located in src/libcamera/include/. The directory is added to the compiler headers search path with a meson include_directories() directive, and internal headers are included with (e.g. for the internal semaphore.h header) #include "semaphore.h" All was well, until libcxx decided to implement the C++20 synchronization library. The __threading_support header gained a #include <semaphore.h> to include the pthread's semaphore support. As include_directories() adds src/libcamera/include/ to the compiler search path with -I, the internal semaphore.h is included instead of the pthread version. Needless to say, the compiler isn't happy. Three options have been considered to fix this issue: - Use -iquote instead of -I. The -iquote option instructs gcc to only consider the header search path for headers included with the "" version. Meson unfortunately doesn't support this option. - Rename the internal semaphore.h header. This was deemed to be the beginning of a long whack-a-mole game, where namespace clashes with system libraries would appear over time (possibly dependent on particular system configurations) and would need to be constantly fixed. - Move the internal headers to another directory to create a unique namespace through path components. This causes lots of churn in all the existing source files through the all project. The first option would be best, but isn't available to us due to missing support in meson. Even if -iquote support was added, we would need to fix the problem before a new version of meson containing the required support would be released. The third option is thus the only practical solution available. Bite the bullet, and do it, moving headers to include/libcamera/internal/. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
78 lines
1.7 KiB
C++
78 lines
1.7 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* libcamera V4L2 Subdevice format handling test
|
|
*/
|
|
|
|
#include <iostream>
|
|
#include <limits.h>
|
|
|
|
#include "libcamera/internal/v4l2_subdevice.h"
|
|
|
|
#include "v4l2_subdevice_test.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
/* Test format handling on the "Scaler" subdevice of vimc media device. */
|
|
|
|
class FormatHandlingTest : public V4L2SubdeviceTest
|
|
{
|
|
protected:
|
|
int run() override;
|
|
};
|
|
|
|
int FormatHandlingTest::run()
|
|
{
|
|
V4L2SubdeviceFormat format = {};
|
|
|
|
/*
|
|
* Get format on a non-existing Scaler pad: expect failure.
|
|
*/
|
|
int ret = scaler_->getFormat(2, &format);
|
|
if (!ret) {
|
|
cerr << "Getting format on a non existing pad should fail" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
ret = scaler_->getFormat(0, &format);
|
|
if (ret) {
|
|
cerr << "Failed to get format" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Set unrealistic image resolutions and make sure it gets updated.
|
|
*/
|
|
format.size = { UINT_MAX, UINT_MAX };
|
|
ret = scaler_->setFormat(0, &format);
|
|
if (ret) {
|
|
cerr << "Failed to set format: image resolution is wrong, but "
|
|
<< "setFormat() should not fail." << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (format.size.width == UINT_MAX ||
|
|
format.size.height == UINT_MAX) {
|
|
cerr << "Failed to update image format" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
format.size = { 0, 0 };
|
|
ret = scaler_->setFormat(0, &format);
|
|
if (ret) {
|
|
cerr << "Failed to set format: image resolution is wrong, but "
|
|
<< "setFormat() should not fail." << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (format.size.width == 0 || format.size.height == 0) {
|
|
cerr << "Failed to update image format" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
TEST_REGISTER(FormatHandlingTest);
|