libcamera/test/v4l2_videodevice/buffer_sharing.cpp
Laurent Pinchart 93e72b695e libcamera: Move internal headers to include/libcamera/internal/
The libcamera internal headers are located in src/libcamera/include/.
The directory is added to the compiler headers search path with a meson
include_directories() directive, and internal headers are included with
(e.g. for the internal semaphore.h header)

  #include "semaphore.h"

All was well, until libcxx decided to implement the C++20
synchronization library. The __threading_support header gained a

  #include <semaphore.h>

to include the pthread's semaphore support. As include_directories()
adds src/libcamera/include/ to the compiler search path with -I, the
internal semaphore.h is included instead of the pthread version.
Needless to say, the compiler isn't happy.

Three options have been considered to fix this issue:

- Use -iquote instead of -I. The -iquote option instructs gcc to only
  consider the header search path for headers included with the ""
  version. Meson unfortunately doesn't support this option.

- Rename the internal semaphore.h header. This was deemed to be the
  beginning of a long whack-a-mole game, where namespace clashes with
  system libraries would appear over time (possibly dependent on
  particular system configurations) and would need to be constantly
  fixed.

- Move the internal headers to another directory to create a unique
  namespace through path components. This causes lots of churn in all
  the existing source files through the all project.

The first option would be best, but isn't available to us due to missing
support in meson. Even if -iquote support was added, we would need to
fix the problem before a new version of meson containing the required
support would be released.

The third option is thus the only practical solution available. Bite the
bullet, and do it, moving headers to include/libcamera/internal/.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Jacopo Mondi <jacopo@jmondi.org>
2020-05-16 03:38:11 +03:00

203 lines
4.5 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* libcamera V4L2 API tests
*
* Validate the function of exporting buffers from a V4L2VideoDevice and
* the ability to import them to another V4L2VideoDevice instance.
* Ensure that the Buffers can successfully be queued and dequeued
* between both devices.
*/
#include <iostream>
#include <libcamera/buffer.h>
#include <libcamera/event_dispatcher.h>
#include <libcamera/timer.h>
#include "libcamera/internal/thread.h"
#include "v4l2_videodevice_test.h"
class BufferSharingTest : public V4L2VideoDeviceTest
{
public:
BufferSharingTest()
: V4L2VideoDeviceTest("vivid", "vivid-000-vid-cap"),
output_(nullptr), framesCaptured_(0), framesOutput_(0) {}
protected:
int init()
{
int ret = V4L2VideoDeviceTest::init();
if (ret)
return ret;
/* media_ already represents VIVID */
MediaEntity *entity = media_->getEntityByName("vivid-000-vid-out");
if (!entity)
return TestSkip;
output_ = new V4L2VideoDevice(entity);
if (!output_) {
std::cout << "Failed to create output device" << std::endl;
return TestFail;
}
ret = output_->open();
if (ret) {
std::cout << "Failed to open output device" << std::endl;
return TestFail;
}
V4L2DeviceFormat format = {};
ret = capture_->getFormat(&format);
if (ret) {
std::cout << "Failed to get capture format" << std::endl;
return TestFail;
}
format.size.width = 320;
format.size.height = 180;
ret = capture_->setFormat(&format);
if (ret) {
std::cout << "Failed to set capture format" << std::endl;
return TestFail;
}
ret = output_->setFormat(&format);
if (ret) {
std::cout << "Failed to set output format" << std::endl;
return TestFail;
}
ret = capture_->allocateBuffers(bufferCount, &buffers_);
if (ret < 0) {
std::cout << "Failed to allocate buffers" << std::endl;
return TestFail;
}
ret = output_->importBuffers(bufferCount);
if (ret < 0) {
std::cout << "Failed to import buffers" << std::endl;
return TestFail;
}
return 0;
}
void captureBufferReady(FrameBuffer *buffer)
{
const FrameMetadata &metadata = buffer->metadata();
std::cout << "Received capture buffer" << std::endl;
if (metadata.status != FrameMetadata::FrameSuccess)
return;
output_->queueBuffer(buffer);
framesCaptured_++;
}
void outputBufferReady(FrameBuffer *buffer)
{
const FrameMetadata &metadata = buffer->metadata();
std::cout << "Received output buffer" << std::endl;
if (metadata.status != FrameMetadata::FrameSuccess)
return;
capture_->queueBuffer(buffer);
framesOutput_++;
}
int run()
{
EventDispatcher *dispatcher = Thread::current()->eventDispatcher();
Timer timeout;
int ret;
capture_->bufferReady.connect(this, &BufferSharingTest::captureBufferReady);
output_->bufferReady.connect(this, &BufferSharingTest::outputBufferReady);
for (const std::unique_ptr<FrameBuffer> &buffer : buffers_) {
if (capture_->queueBuffer(buffer.get())) {
std::cout << "Failed to queue buffer" << std::endl;
return TestFail;
}
}
ret = capture_->streamOn();
if (ret) {
std::cout << "Failed to start streaming on the capture device" << std::endl;
return TestFail;
}
ret = output_->streamOn();
if (ret) {
std::cout << "Failed to start streaming on the output device" << std::endl;
return TestFail;
}
timeout.start(10000);
while (timeout.isRunning()) {
dispatcher->processEvents();
if (framesCaptured_ > 30 && framesOutput_ > 30)
break;
}
if ((framesCaptured_ < 1) || (framesOutput_ < 1)) {
std::cout << "Failed to process any frames within timeout." << std::endl;
return TestFail;
}
if ((framesCaptured_ < 30) || (framesOutput_ < 30)) {
std::cout << "Failed to process 30 frames within timeout." << std::endl;
return TestFail;
}
ret = capture_->streamOff();
if (ret) {
std::cout << "Failed to stop streaming on the capture device" << std::endl;
return TestFail;
}
ret = output_->streamOff();
if (ret) {
std::cout << "Failed to stop streaming on the output device" << std::endl;
return TestFail;
}
return TestPass;
}
void cleanup()
{
std::cout
<< "Captured " << framesCaptured_ << " frames and "
<< "output " << framesOutput_ << " frames"
<< std::endl;
output_->streamOff();
output_->releaseBuffers();
output_->close();
delete output_;
V4L2VideoDeviceTest::cleanup();
}
private:
const unsigned int bufferCount = 4;
V4L2VideoDevice *output_;
unsigned int framesCaptured_;
unsigned int framesOutput_;
};
TEST_REGISTER(BufferSharingTest);