ConnectionTypeBlocking always invokes the method through inter-thread message passing, which results in deadlocks if the sender and receiver live in the same thread. The deadlock can easily be avoided by turning the invocation into a direct call in this case. Do so to make ConnectionTypeBlocking easier to use when some of the senders live in the same thread as the receiver while the other senders don't. Extend the object-invoke test to cover this usage. While at it reformat the documentation to avoid long \brief lines. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
203 lines
4.3 KiB
C++
203 lines
4.3 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* object-invoke.cpp - Cross-thread Object method invocation test
|
|
*/
|
|
|
|
#include <iostream>
|
|
#include <thread>
|
|
|
|
#include <libcamera/event_dispatcher.h>
|
|
#include <libcamera/object.h>
|
|
|
|
#include "test.h"
|
|
#include "thread.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class InvokedObject : public Object
|
|
{
|
|
public:
|
|
enum Status {
|
|
NoCall,
|
|
InvalidThread,
|
|
CallReceived,
|
|
};
|
|
|
|
InvokedObject()
|
|
: status_(NoCall)
|
|
{
|
|
}
|
|
|
|
Status status() const { return status_; }
|
|
int value() const { return value_; }
|
|
void reset()
|
|
{
|
|
status_ = NoCall;
|
|
value_ = 0;
|
|
}
|
|
|
|
void method(int value)
|
|
{
|
|
if (Thread::current() != thread())
|
|
status_ = InvalidThread;
|
|
else
|
|
status_ = CallReceived;
|
|
|
|
value_ = value;
|
|
}
|
|
|
|
void methodWithReference(const int &value)
|
|
{
|
|
}
|
|
|
|
int methodWithReturn()
|
|
{
|
|
return 42;
|
|
}
|
|
|
|
private:
|
|
Status status_;
|
|
int value_;
|
|
};
|
|
|
|
class ObjectInvokeTest : public Test
|
|
{
|
|
protected:
|
|
int run()
|
|
{
|
|
EventDispatcher *dispatcher = Thread::current()->eventDispatcher();
|
|
|
|
/*
|
|
* Test that queued method invocation in the same thread goes
|
|
* through the event dispatcher.
|
|
*/
|
|
object_.invokeMethod(&InvokedObject::method,
|
|
ConnectionTypeQueued, 42);
|
|
|
|
if (object_.status() != InvokedObject::NoCall) {
|
|
cerr << "Method not invoked asynchronously" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
dispatcher->processEvents();
|
|
|
|
switch (object_.status()) {
|
|
case InvokedObject::NoCall:
|
|
cout << "Method not invoked for main thread" << endl;
|
|
return TestFail;
|
|
case InvokedObject::InvalidThread:
|
|
cout << "Method invoked in incorrect thread for main thread" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
if (object_.value() != 42) {
|
|
cout << "Method invoked with incorrect value for main thread" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test that blocking invocation is delivered directly when the
|
|
* caller and callee live in the same thread.
|
|
*/
|
|
object_.reset();
|
|
|
|
object_.invokeMethod(&InvokedObject::method,
|
|
ConnectionTypeBlocking, 42);
|
|
|
|
switch (object_.status()) {
|
|
case InvokedObject::NoCall:
|
|
cout << "Method not invoked for main thread (blocking)" << endl;
|
|
return TestFail;
|
|
case InvokedObject::InvalidThread:
|
|
cout << "Method invoked in incorrect thread for main thread (blocking)" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* Move the object to a thread and verify that auto method
|
|
* invocation is delivered in the correct thread.
|
|
*/
|
|
object_.reset();
|
|
object_.moveToThread(&thread_);
|
|
|
|
thread_.start();
|
|
|
|
object_.invokeMethod(&InvokedObject::method,
|
|
ConnectionTypeBlocking, 42);
|
|
|
|
switch (object_.status()) {
|
|
case InvokedObject::NoCall:
|
|
cout << "Method not invoked for custom thread" << endl;
|
|
return TestFail;
|
|
case InvokedObject::InvalidThread:
|
|
cout << "Method invoked in incorrect thread for custom thread" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
if (object_.value() != 42) {
|
|
cout << "Method invoked with incorrect value for custom thread" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/* Test that direct method invocation bypasses threads. */
|
|
object_.reset();
|
|
object_.invokeMethod(&InvokedObject::method,
|
|
ConnectionTypeDirect, 42);
|
|
|
|
switch (object_.status()) {
|
|
case InvokedObject::NoCall:
|
|
cout << "Method not invoked for custom thread" << endl;
|
|
return TestFail;
|
|
case InvokedObject::CallReceived:
|
|
cout << "Method invoked in incorrect thread for direct call" << endl;
|
|
return TestFail;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
if (object_.value() != 42) {
|
|
cout << "Method invoked with incorrect value for direct call" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
/*
|
|
* Test invoking a method that takes reference arguments. This
|
|
* targets compilation, there's no need to check runtime
|
|
* results.
|
|
*/
|
|
object_.invokeMethod(&InvokedObject::methodWithReference,
|
|
ConnectionTypeBlocking, 42);
|
|
|
|
/* Test invoking a method that returns a value. */
|
|
int ret = object_.invokeMethod(&InvokedObject::methodWithReturn,
|
|
ConnectionTypeBlocking);
|
|
if (ret != 42) {
|
|
cout << "Method invoked return incorrect value (" << ret
|
|
<< ")" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
thread_.exit(0);
|
|
thread_.wait();
|
|
}
|
|
|
|
private:
|
|
Thread thread_;
|
|
InvokedObject object_;
|
|
};
|
|
|
|
TEST_REGISTER(ObjectInvokeTest)
|