Working on SoftISP
a6799dc5b9
The CameraHalManager::getCameraInfo() validates the camera id it
receives from the camera service, and in doing so compares it with an
unsigned integer, generating a compiler error:
src/android/camera_hal_manager.cpp:121:9: error: comparison of integers of different signs: 'int' and 'unsigned int' [-Werror,-Wsign-compare]
if (id >= numCameras() || id < 0) {
~~ ^ ~~~~~~~~~~~~
Fix this by turning the id into an unsigned int, as camera ids can't be
negative. If a negative id is received from the camera service it will
be converted to a large unsigned integer that will fail the comparison
with numCameras().
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
|
||
|---|---|---|
| Documentation | ||
| include | ||
| licenses | ||
| package/gentoo/media-libs/libcamera | ||
| src | ||
| test | ||
| utils | ||
| .clang-format | ||
| .gitignore | ||
| meson.build | ||
| meson_options.txt | ||
| README.md | ||
libcamera: A complex camera support library for Linux, Android, and ChromeOS
To build and install:
meson build
cd build
ninja
ninja install