46340ced12
Multistream test failed with the following logs, to run on Raspberry Pi 4 due
to a bug introduced in one of the recent patches refactoring the code
that fails to set the camera-name property with a valid camera id
string.
WARN libcamerasrc gstlibcamerasrc.cpp:347:gst_libcamera_src_open:<libcamera> error: Could not find a camera named ''.
WARN libcamerasrc gstlibcamerasrc.cpp:347:gst_libcamera_src_open:<libcamera> error: libcamera::CameraMananger::get() returned nullptr
This patch assigns the camera->id() to the variable cameraName_ that is
later used to set element property "camera-name" needed to call the
specific camera which supports multistreams. Move the code to set
element property "camera-name" to base class GstreamerTest.
Fixes: 5646849b59 ("test: gstreamer: Check availability of cameras before running")
Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>
Reviewed-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
111 lines
2.5 KiB
C++
111 lines
2.5 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2021, Vedant Paranjape
|
|
*
|
|
* gstreamer_multi_stream_test.cpp - GStreamer multi stream capture test
|
|
*/
|
|
|
|
#include <iostream>
|
|
#include <unistd.h>
|
|
|
|
#include <libcamera/libcamera.h>
|
|
|
|
#include <gst/gst.h>
|
|
|
|
#include "gstreamer_test.h"
|
|
#include "test.h"
|
|
|
|
#if !GST_CHECK_VERSION(1, 19, 1)
|
|
static inline GstPad *gst_element_request_pad_simple(GstElement *element,
|
|
const gchar *name)
|
|
{
|
|
return gst_element_get_request_pad(element, name);
|
|
}
|
|
#endif
|
|
|
|
using namespace std;
|
|
|
|
class GstreamerMultiStreamTest : public GstreamerTest, public Test
|
|
{
|
|
public:
|
|
GstreamerMultiStreamTest()
|
|
: GstreamerTest(2)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
int init() override
|
|
{
|
|
if (status_ != TestPass)
|
|
return status_;
|
|
|
|
const gchar *streamDescription = "queue ! fakesink";
|
|
g_autoptr(GError) error = NULL;
|
|
|
|
stream0_ = gst_parse_bin_from_description_full(streamDescription, TRUE,
|
|
NULL,
|
|
GST_PARSE_FLAG_FATAL_ERRORS,
|
|
&error);
|
|
if (!stream0_) {
|
|
g_printerr("Stream0 could not be created (%s)\n", error->message);
|
|
return TestFail;
|
|
}
|
|
g_object_ref_sink(stream0_);
|
|
|
|
stream1_ = gst_parse_bin_from_description_full(streamDescription, TRUE,
|
|
NULL,
|
|
GST_PARSE_FLAG_FATAL_ERRORS,
|
|
&error);
|
|
if (!stream1_) {
|
|
g_printerr("Stream1 could not be created (%s)\n", error->message);
|
|
return TestFail;
|
|
}
|
|
g_object_ref_sink(stream1_);
|
|
|
|
if (createPipeline() != TestPass)
|
|
return TestFail;
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
int run() override
|
|
{
|
|
/* Build the pipeline */
|
|
gst_bin_add_many(GST_BIN(pipeline_), libcameraSrc_,
|
|
stream0_, stream1_, NULL);
|
|
|
|
g_autoptr(GstPad) src_pad = gst_element_get_static_pad(libcameraSrc_, "src");
|
|
g_autoptr(GstPad) request_pad = gst_element_request_pad_simple(libcameraSrc_, "src_%u");
|
|
|
|
{
|
|
g_autoptr(GstPad) queue0_sink_pad = gst_element_get_static_pad(stream0_, "sink");
|
|
g_autoptr(GstPad) queue1_sink_pad = gst_element_get_static_pad(stream1_, "sink");
|
|
|
|
if (gst_pad_link(src_pad, queue0_sink_pad) != GST_PAD_LINK_OK ||
|
|
gst_pad_link(request_pad, queue1_sink_pad) != GST_PAD_LINK_OK) {
|
|
g_printerr("Pads could not be linked.\n");
|
|
return TestFail;
|
|
}
|
|
}
|
|
|
|
if (startPipeline() != TestPass)
|
|
return TestFail;
|
|
|
|
if (processEvent() != TestPass)
|
|
return TestFail;
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup() override
|
|
{
|
|
g_clear_object(&stream0_);
|
|
g_clear_object(&stream1_);
|
|
}
|
|
|
|
private:
|
|
GstElement *stream0_;
|
|
GstElement *stream1_;
|
|
};
|
|
|
|
TEST_REGISTER(GstreamerMultiStreamTest)
|