Source files in libcamera start by a comment block header, which includes the file name and a one-line description of the file contents. While the latter is useful to get a quick overview of the file contents at a glance, the former is mostly a source of inconvenience. The name in the comments can easily get out of sync with the file name when files are renamed, and copy & paste during development have often lead to incorrect names being used to start with. Readers of the source code are expected to know which file they're looking it. Drop the file name from the header comment block. The change was generated with the following script: ---------------------------------------- dirs="include/libcamera src test utils" declare -rA patterns=( ['c']=' \* ' ['cpp']=' \* ' ['h']=' \* ' ['py']='# ' ['sh']='# ' ) for ext in ${!patterns[@]} ; do files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done) pattern=${patterns[${ext}]} for file in $files ; do name=$(basename ${file}) sed -i "s/^\(${pattern}\)${name} - /\1/" "$file" done done ---------------------------------------- This misses several files that are out of sync with the comment block header. Those will be addressed separately and manually. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
149 lines
3.8 KiB
Python
149 lines
3.8 KiB
Python
# SPDX-License-Identifier: BSD-2-Clause
|
|
#
|
|
# Copyright (C) 2019, Raspberry Pi Ltd
|
|
#
|
|
# camera tuning tool miscellaneous
|
|
|
|
import time
|
|
import re
|
|
import binascii
|
|
import os
|
|
import cv2
|
|
import numpy as np
|
|
import imutils
|
|
import sys
|
|
import matplotlib.pyplot as plt
|
|
from sklearn import cluster as cluster
|
|
from sklearn.neighbors import NearestCentroid as get_centroids
|
|
|
|
"""
|
|
This file contains some useful tools, the details of which aren't important to
|
|
understanding of the code. They ar collated here to attempt to improve code
|
|
readability in the main files.
|
|
"""
|
|
|
|
|
|
"""
|
|
obtain config values, unless it doesnt exist, in which case pick default
|
|
Furthermore, it can check if the input is the correct type
|
|
"""
|
|
def get_config(dictt, key, default, ttype):
|
|
try:
|
|
val = dictt[key]
|
|
if ttype == 'string':
|
|
val = str(val)
|
|
elif ttype == 'num':
|
|
if 'int' not in str(type(val)):
|
|
if 'float' not in str(type(val)):
|
|
raise ValueError
|
|
elif ttype == 'dict':
|
|
if not isinstance(val, dict):
|
|
raise ValueError
|
|
elif ttype == 'list':
|
|
if not isinstance(val, list):
|
|
raise ValueError
|
|
elif ttype == 'bool':
|
|
ttype = int(bool(ttype))
|
|
else:
|
|
val = dictt[key]
|
|
except (KeyError, ValueError):
|
|
val = default
|
|
return val
|
|
|
|
|
|
"""
|
|
argument parser
|
|
"""
|
|
def parse_input():
|
|
arguments = sys.argv[1:]
|
|
if len(arguments) % 2 != 0:
|
|
raise ArgError('\n\nERROR! Enter value for each arguent passed.')
|
|
params = arguments[0::2]
|
|
vals = arguments[1::2]
|
|
args_dict = dict(zip(params, vals))
|
|
json_output = get_config(args_dict, '-o', None, 'string')
|
|
directory = get_config(args_dict, '-i', None, 'string')
|
|
config = get_config(args_dict, '-c', None, 'string')
|
|
log_path = get_config(args_dict, '-l', None, 'string')
|
|
if directory is None:
|
|
raise ArgError('\n\nERROR! No input directory given.')
|
|
if json_output is None:
|
|
raise ArgError('\n\nERROR! No output json given.')
|
|
return json_output, directory, config, log_path
|
|
|
|
|
|
"""
|
|
custom arg and macbeth error class
|
|
"""
|
|
class ArgError(Exception):
|
|
pass
|
|
class MacbethError(Exception):
|
|
pass
|
|
|
|
|
|
"""
|
|
correlation function to quantify match
|
|
"""
|
|
def correlate(im1, im2):
|
|
f1 = im1.flatten()
|
|
f2 = im2.flatten()
|
|
cor = np.corrcoef(f1, f2)
|
|
return cor[0][1]
|
|
|
|
|
|
"""
|
|
get list of files from directory
|
|
"""
|
|
def get_photos(directory='photos'):
|
|
filename_list = []
|
|
for filename in os.listdir(directory):
|
|
if 'jp' in filename or '.dng' in filename:
|
|
filename_list.append(filename)
|
|
return filename_list
|
|
|
|
|
|
"""
|
|
display image for debugging... read at your own risk...
|
|
"""
|
|
def represent(img, name='image'):
|
|
# if type(img) == tuple or type(img) == list:
|
|
# for i in range(len(img)):
|
|
# name = 'image {}'.format(i)
|
|
# cv2.imshow(name, img[i])
|
|
# else:
|
|
# cv2.imshow(name, img)
|
|
# cv2.waitKey(0)
|
|
# cv2.destroyAllWindows()
|
|
# return 0
|
|
"""
|
|
code above displays using opencv, but this doesn't catch users pressing 'x'
|
|
with their mouse to close the window.... therefore matplotlib is used....
|
|
(thanks a lot opencv)
|
|
"""
|
|
grid = plt.GridSpec(22, 1)
|
|
plt.subplot(grid[:19, 0])
|
|
plt.imshow(img, cmap='gray')
|
|
plt.axis('off')
|
|
plt.subplot(grid[21, 0])
|
|
plt.title('press \'q\' to continue')
|
|
plt.axis('off')
|
|
plt.show()
|
|
|
|
# f = plt.figure()
|
|
# ax = f.add_subplot(211)
|
|
# ax2 = f.add_subplot(122)
|
|
# ax.imshow(img, cmap='gray')
|
|
# ax.axis('off')
|
|
# ax2.set_figheight(2)
|
|
# ax2.title('press \'q\' to continue')
|
|
# ax2.axis('off')
|
|
# plt.show()
|
|
|
|
|
|
"""
|
|
reshape image to fixed width without distorting
|
|
returns image and scale factor
|
|
"""
|
|
def reshape(img, width):
|
|
factor = width/img.shape[0]
|
|
return cv2.resize(img, None, fx=factor, fy=factor), factor
|