NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions
libcamera/test
History
Laurent Pinchart 3335d5a504 libcamera: Drop emitter object pointer from signal arguments 
Many signals used in internal and public APIs carry the emitter pointer
as a signal argument. This was done to allow slots connected to multiple
signal instances to differentiate between emitters. While starting from
a good intention of facilitating the implementation of slots, it turned
out to be a bad API design as the signal isn't meant to know what it
will be connected to, and thus shouldn't carry parameters that are
solely meant to support a use case specific to the connected slot.

These pointers turn out to be unused in all slots but one. In the only
case where it is needed, it can be obtained by wrapping the slot in a
lambda function when connecting the signal. Do so, and drop the emitter
pointer from all signals.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
2021-09-02 01:16:45 +03:00
..
camera libcamera: Use simpler Signal::disconnect() function 2021-09-02 01:16:44 +03:00
controls controls: Add boolean constructors for ControlInfo 2021-08-02 18:07:16 +09:00
gstreamer test: gstreamer: Disable gstreamer registry forks 2021-08-26 16:36:14 +03:00
ipa libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
ipc libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
libtest libtest: camera_test: Plumb constructor to set LIBCAMERA_IPA_FORCE_ISOLATION 2021-08-19 12:54:03 +05:30
log libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
media_device libcamera: Rename 'method' to 'function' 2021-08-09 15:40:32 +03:00
pipeline libcamera/base: Validate internal headers as private 2021-06-25 16:11:11 +01:00
process libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
serialization ipa: Use FileDescriptor instead of int in layers above IPC payload 2021-08-19 16:54:02 +09:00
stream libcamera: rename public libcamera dependency 2021-06-25 16:11:11 +01:00
v4l2_compat test: v4l2_compat: Disable test when ASan is enabled 2021-09-01 13:09:18 +03:00
v4l2_subdevice libcamera: buffer: Rename buffer.h to framebuffer.h 2021-07-11 17:42:02 +03:00
v4l2_videodevice libcamera: buffer: Rename buffer.h to framebuffer.h 2021-07-11 17:42:02 +03:00
bayer-format.cpp test: bayer-format: Rectify internal header's #include path 2021-05-05 10:32:33 +02:00
byte-stream-buffer.cpp test: byte-stream-buffer: Initialize data array 2021-05-26 10:24:15 +02:00
camera-sensor.cpp libcamera: camera_sensor: Transform CameraSensor::sizes() 2021-08-31 12:26:54 +05:30
delayed_controls.cpp test: delayed_controls: Rename delayed_contols.cpp to delayed_controls.cpp 2021-03-12 14:20:51 +00:00
event-dispatcher.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
event-thread.cpp libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
event.cpp libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
file-descriptor.cpp libcamera/base: Move utils to the base library 2021-06-25 16:11:02 +01:00
file.cpp libcamera: file: Turn MapFlag and OpenModeFlag into enum class 2021-08-03 10:55:33 +03:00
flags.cpp test: Add tests for the Flags class 2021-08-03 10:55:21 +03:00
geometry.cpp test: geometry: Add unit tests for new geometry helper functions 2020-10-27 14:06:51 +02:00
hotplug-cameras.cpp libcamera/base: Move File to base library 2021-06-25 16:11:10 +01:00
mapped-buffer.cpp libcamera: MappedFrameBuffer: Use typed Flags<MapModes> 2021-08-10 10:57:04 +01:00
meson.build test: gstreamer: Add test for gstreamer single stream 2021-08-14 22:58:46 +03:00
message.cpp test: message: Test recursive Thread::dispatchMessages() calls 2021-07-11 17:41:59 +03:00
object-delete.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
object-invoke.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
object.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
pixel-format.cpp libcamera/base: Move utils to the base library 2021-06-25 16:11:02 +01:00
public-api.cpp test: Ensure LIBCAMERA_BASE_PRIVATE isn't public 2021-06-25 16:11:11 +01:00
signal-threads.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
signal.cpp libcamera: base: signal: Support connecting signals to functors 2021-09-02 01:16:45 +03:00
span.cpp libcamera/base: Move span to base library 2021-06-25 16:11:11 +01:00
threads.cpp libcamera/base: Move extended base functionality 2021-06-25 16:11:08 +01:00
timer-thread.cpp libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
timer.cpp libcamera: Drop emitter object pointer from signal arguments 2021-09-02 01:16:45 +03:00
utils.cpp libcamera/base: Move span to base library 2021-06-25 16:11:11 +01:00