libcamera/src
Laurent Pinchart a8b472598e hal: Fix comparison of unsigned integer < 0
The CameraHalManager::getCameraInfo() validates the camera id it
receives from the camera service, and in doing so generates a compiler
error with gcc as the id is an unsigned integer and can never be
negative:

../src/android/camera_hal_manager.cpp: In member function ‘CameraProxy* CameraHalManager::open(unsigned int, const hw_module_t*)’:
../src/android/camera_hal_manager.cpp:89:9: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
  if (id < 0 || id >= numCameras()) {

Fix it by removing the unneeded comparison.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
2019-08-15 15:40:14 +03:00
..
android hal: Fix comparison of unsigned integer < 0 2019-08-15 15:40:14 +03:00
cam libcamera: buffer: Add an accessor to the BufferMemory 2019-07-14 16:01:07 +03:00
ipa libcamera: ipa: meson: build dummy IPA that needs isolation 2019-07-12 16:32:29 +09:00
libcamera libcamera: v4l2_videodevice: Support M2M devices 2019-08-13 15:36:04 +01:00
qcam libcamera: qcam: Allow specifying sizes on command line 2019-07-17 04:49:38 +02:00
meson.build android: hal: Add Camera3 HAL 2019-08-12 11:55:46 +02:00