libcamera/src/ipa/rkisp1/ipa_context.h
Stefan Klug f1ac420eb1 ipa: rkisp1: ccm/lsc: Fix CCM/LSC based on manual color temperature
In RkISP1Awb::process(), the color temperature in the active state is
updated every time new statistics are available.  The CCM/LSC algorithms
use that value in prepare() to update the CCM/LSC. This is not correct
if the color temperature was specified manually and leads to visible
flicker even when AwbEnable is set to false.

To fix that, track the auto and manual color temperature separately in
active state. In Awb::prepare() the current frame context is updated
with the corresponding value from active state. Change the algorithms to
fetch the color temperature from the frame context instead of the active
state in prepare().

Fixes: 0230880954 ("ipa: rkisp1: awb: Implement ColourTemperature control")
Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
2025-05-20 11:16:36 +02:00

211 lines
3.5 KiB
C++

/* SPDX-License-Identifier: LGPL-2.1-or-later */
/*
* Copyright (C) 2021-2022, Ideas On Board
*
* RkISP1 IPA Context
*
*/
#pragma once
#include <memory>
#include <linux/rkisp1-config.h>
#include <libcamera/base/utils.h>
#include <libcamera/control_ids.h>
#include <libcamera/controls.h>
#include <libcamera/geometry.h>
#include <libcamera/ipa/core_ipa_interface.h>
#include "libcamera/internal/debug_controls.h"
#include "libcamera/internal/matrix.h"
#include "libcamera/internal/vector.h"
#include <libipa/camera_sensor_helper.h>
#include <libipa/fc_queue.h>
namespace libcamera {
namespace ipa::rkisp1 {
struct IPAHwSettings {
unsigned int numAeCells;
unsigned int numHistogramBins;
unsigned int numHistogramWeights;
unsigned int numGammaOutSamples;
bool compand;
};
struct IPASessionConfiguration {
struct {
struct rkisp1_cif_isp_window measureWindow;
} agc;
struct {
struct rkisp1_cif_isp_window measureWindow;
bool enabled;
} awb;
struct {
bool enabled;
} lsc;
struct {
utils::Duration minExposureTime;
utils::Duration maxExposureTime;
double minAnalogueGain;
double maxAnalogueGain;
int32_t defVBlank;
utils::Duration lineDuration;
Size size;
} sensor;
bool raw;
uint32_t paramFormat;
};
struct IPAActiveState {
struct {
struct {
uint32_t exposure;
double gain;
} manual;
struct {
uint32_t exposure;
double gain;
} automatic;
bool autoExposureEnabled;
bool autoGainEnabled;
controls::AeConstraintModeEnum constraintMode;
controls::AeExposureModeEnum exposureMode;
controls::AeMeteringModeEnum meteringMode;
utils::Duration minFrameDuration;
utils::Duration maxFrameDuration;
} agc;
struct {
struct AwbState {
RGB<double> gains;
unsigned int temperatureK;
};
AwbState manual;
AwbState automatic;
bool autoEnabled;
} awb;
struct {
Matrix<float, 3, 3> ccm;
} ccm;
struct {
int8_t brightness;
uint8_t contrast;
uint8_t saturation;
} cproc;
struct {
bool denoise;
} dpf;
struct {
uint8_t denoise;
uint8_t sharpness;
} filter;
struct {
double gamma;
} goc;
};
struct IPAFrameContext : public FrameContext {
struct {
uint32_t exposure;
double gain;
uint32_t vblank;
bool autoExposureEnabled;
bool autoGainEnabled;
controls::AeConstraintModeEnum constraintMode;
controls::AeExposureModeEnum exposureMode;
controls::AeMeteringModeEnum meteringMode;
utils::Duration minFrameDuration;
utils::Duration maxFrameDuration;
utils::Duration frameDuration;
bool updateMetering;
bool autoExposureModeChange;
bool autoGainModeChange;
} agc;
struct {
RGB<double> gains;
bool autoEnabled;
unsigned int temperatureK;
} awb;
struct {
int8_t brightness;
uint8_t contrast;
uint8_t saturation;
bool update;
} cproc;
struct {
bool denoise;
bool update;
} dpf;
struct {
uint8_t denoise;
uint8_t sharpness;
bool update;
} filter;
struct {
double gamma;
bool update;
} goc;
struct {
uint32_t exposure;
double gain;
} sensor;
struct {
Matrix<float, 3, 3> ccm;
} ccm;
struct {
double lux;
} lux;
};
struct IPAContext {
IPAContext(unsigned int frameContextSize)
: hw(nullptr), frameContexts(frameContextSize)
{
}
const IPAHwSettings *hw;
IPACameraSensorInfo sensorInfo;
IPASessionConfiguration configuration;
IPAActiveState activeState;
FCQueue<IPAFrameContext> frameContexts;
ControlInfoMap::Map ctrlMap;
DebugMetadata debugMetadata;
/* Interface to the Camera Helper */
std::unique_ptr<CameraSensorHelper> camHelper;
};
} /* namespace ipa::rkisp1 */
} /* namespace libcamera*/