Source files in libcamera start by a comment block header, which includes the file name and a one-line description of the file contents. While the latter is useful to get a quick overview of the file contents at a glance, the former is mostly a source of inconvenience. The name in the comments can easily get out of sync with the file name when files are renamed, and copy & paste during development have often lead to incorrect names being used to start with. Readers of the source code are expected to know which file they're looking it. Drop the file name from the header comment block. The change was generated with the following script: ---------------------------------------- dirs="include/libcamera src test utils" declare -rA patterns=( ['c']=' \* ' ['cpp']=' \* ' ['h']=' \* ' ['py']='# ' ['sh']='# ' ) for ext in ${!patterns[@]} ; do files=$(for dir in $dirs ; do find $dir -name "*.${ext}" ; done) pattern=${patterns[${ext}]} for file in $files ; do name=$(basename ${file}) sed -i "s/^\(${pattern}\)${name} - /\1/" "$file" done done ---------------------------------------- This misses several files that are out of sync with the comment block header. Those will be addressed separately and manually. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
165 lines
3.3 KiB
C++
165 lines
3.3 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* Logging in isolated child process test
|
|
*/
|
|
|
|
#include <fcntl.h>
|
|
#include <iostream>
|
|
#include <random>
|
|
#include <string.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
#include <vector>
|
|
|
|
#include <libcamera/logging.h>
|
|
|
|
#include <libcamera/base/event_dispatcher.h>
|
|
#include <libcamera/base/log.h>
|
|
#include <libcamera/base/thread.h>
|
|
#include <libcamera/base/timer.h>
|
|
#include <libcamera/base/utils.h>
|
|
|
|
#include "libcamera/internal/process.h"
|
|
|
|
#include "test.h"
|
|
|
|
using namespace libcamera;
|
|
using namespace std;
|
|
using namespace std::chrono_literals;
|
|
|
|
static const string message("hello from the child");
|
|
|
|
LOG_DEFINE_CATEGORY(LogProcessTest)
|
|
|
|
class LogProcessTestChild
|
|
{
|
|
public:
|
|
int run(int status, int num)
|
|
{
|
|
usleep(50000);
|
|
|
|
string logPath = "/tmp/libcamera.worker.test." +
|
|
to_string(num) + ".log";
|
|
if (logSetFile(logPath.c_str()) < 0)
|
|
return TestSkip;
|
|
|
|
LOG(LogProcessTest, Warning) << message;
|
|
|
|
return status;
|
|
}
|
|
};
|
|
|
|
class LogProcessTest : public Test
|
|
{
|
|
protected:
|
|
int init()
|
|
{
|
|
random_device random;
|
|
num_ = random();
|
|
logPath_ = "/tmp/libcamera.worker.test." +
|
|
to_string(num_) + ".log";
|
|
|
|
proc_.finished.connect(this, &LogProcessTest::procFinished);
|
|
return 0;
|
|
}
|
|
|
|
int run()
|
|
{
|
|
EventDispatcher *dispatcher = Thread::current()->eventDispatcher();
|
|
Timer timeout;
|
|
|
|
int exitCode = 42;
|
|
vector<std::string> args;
|
|
args.push_back(to_string(exitCode));
|
|
args.push_back(to_string(num_));
|
|
int ret = proc_.start(self(), args);
|
|
if (ret) {
|
|
cerr << "failed to start process" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
timeout.start(2s);
|
|
while (timeout.isRunning())
|
|
dispatcher->processEvents();
|
|
|
|
if (exitStatus_ != Process::NormalExit) {
|
|
cerr << "process did not exit normally: " << exitStatus_
|
|
<< endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (exitCode_ == TestSkip)
|
|
return TestSkip;
|
|
|
|
if (exitCode_ != exitCode) {
|
|
cerr << "exit code should be " << exitCode
|
|
<< ", actual is " << exitCode_ << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
int fd = open(logPath_.c_str(), O_RDONLY, S_IRUSR);
|
|
if (fd < 0) {
|
|
cerr << "failed to open tmp log file" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
char buf[200];
|
|
memset(buf, 0, sizeof(buf));
|
|
if (read(fd, buf, sizeof(buf)) < 0) {
|
|
cerr << "Failed to read tmp log file" << endl;
|
|
close(fd);
|
|
return TestFail;
|
|
}
|
|
close(fd);
|
|
|
|
string str(buf);
|
|
if (str.find(message) == string::npos) {
|
|
cerr << "Received message is not correct (received "
|
|
<< str.length() << " bytes)" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
void cleanup()
|
|
{
|
|
unlink(logPath_.c_str());
|
|
}
|
|
|
|
private:
|
|
void procFinished(enum Process::ExitStatus exitStatus, int exitCode)
|
|
{
|
|
exitStatus_ = exitStatus;
|
|
exitCode_ = exitCode;
|
|
}
|
|
|
|
ProcessManager processManager_;
|
|
|
|
Process proc_;
|
|
Process::ExitStatus exitStatus_ = Process::NotExited;
|
|
string logPath_;
|
|
int exitCode_;
|
|
int num_;
|
|
};
|
|
|
|
/*
|
|
* Can't use TEST_REGISTER() as single binary needs to act as both
|
|
* parent and child processes.
|
|
*/
|
|
int main(int argc, char **argv)
|
|
{
|
|
if (argc == 3) {
|
|
int status = std::stoi(argv[1]);
|
|
int num = std::stoi(argv[2]);
|
|
LogProcessTestChild child;
|
|
return child.run(status, num);
|
|
}
|
|
|
|
LogProcessTest test;
|
|
test.setArgs(argc, argv);
|
|
return test.execute();
|
|
}
|