ff09b6d378
The process test runs for just 100mS. The spawned process runs for at least 50mS. Ordinarily this should allow plenty of time for both the process to be spawned and run, but when adding extra debug instrumentation, the processes can be slowed down, leading to a false negative test failure. Extend the timeout to 2 seconds to allow the short process to be run correctly - but use the now initialised exitStatus_ to exit the event loop as soon as the process has completed. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
102 lines
1.9 KiB
C++
102 lines
1.9 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2019, Google Inc.
|
|
*
|
|
* process_test.cpp - Process test
|
|
*/
|
|
|
|
#include <iostream>
|
|
#include <unistd.h>
|
|
#include <vector>
|
|
|
|
#include <libcamera/event_dispatcher.h>
|
|
#include <libcamera/timer.h>
|
|
|
|
#include "process.h"
|
|
#include "test.h"
|
|
#include "thread.h"
|
|
#include "utils.h"
|
|
|
|
using namespace std;
|
|
using namespace libcamera;
|
|
|
|
class ProcessTestChild
|
|
{
|
|
public:
|
|
int run(int status)
|
|
{
|
|
usleep(50000);
|
|
|
|
return status;
|
|
}
|
|
};
|
|
|
|
class ProcessTest : public Test
|
|
{
|
|
public:
|
|
ProcessTest()
|
|
: exitStatus_(Process::NotExited), exitCode_(-1)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
int run()
|
|
{
|
|
EventDispatcher *dispatcher = Thread::current()->eventDispatcher();
|
|
Timer timeout;
|
|
|
|
int exitCode = 42;
|
|
vector<std::string> args;
|
|
args.push_back(to_string(exitCode));
|
|
proc_.finished.connect(this, &ProcessTest::procFinished);
|
|
|
|
int ret = proc_.start("/proc/self/exe", args);
|
|
if (ret) {
|
|
cerr << "failed to start process" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
timeout.start(2000);
|
|
while (timeout.isRunning() && exitStatus_ == Process::NotExited)
|
|
dispatcher->processEvents();
|
|
|
|
if (exitStatus_ != Process::NormalExit) {
|
|
cerr << "process did not exit normally" << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
if (exitCode != exitCode_) {
|
|
cerr << "exit code should be " << exitCode
|
|
<< ", actual is " << exitCode_ << endl;
|
|
return TestFail;
|
|
}
|
|
|
|
return TestPass;
|
|
}
|
|
|
|
private:
|
|
void procFinished(Process *proc, enum Process::ExitStatus exitStatus, int exitCode)
|
|
{
|
|
exitStatus_ = exitStatus;
|
|
exitCode_ = exitCode;
|
|
}
|
|
|
|
Process proc_;
|
|
enum Process::ExitStatus exitStatus_;
|
|
int exitCode_;
|
|
};
|
|
|
|
/*
|
|
* Can't use TEST_REGISTER() as single binary needs to act as both
|
|
* parent and child processes.
|
|
*/
|
|
int main(int argc, char **argv)
|
|
{
|
|
if (argc == 2) {
|
|
int status = std::stoi(argv[1]);
|
|
ProcessTestChild child;
|
|
return child.run(status);
|
|
}
|
|
|
|
return ProcessTest().execute();
|
|
}
|