Mirror/betaflight-configurator
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight-configurator.git synced 2025-07-17 21:35:33 +03:00
Code Issues Wiki Activity

Fix storage key name for caching the jenkins builds list.

Browse source 
Due to regular quotes being used in `jenkins_loader.js` instead of backticks the current JobsData is cached as
"${viewUrl}JobsData"
"${viewUrl}JobsLastUpdate"

Instead of something like:
"https://ci.betaflight.tech/view/Firmware_JobsData"
"https://ci.betaflight.tech/view/Firmware_JobsLastUpdate"

Another idea would be to do "jenkinsJobsData" and "jenkinsJobsLastUpdate" to match with the other cache keys

I've chosen to add an underscore in between the URL and the rest of the key to make it easier to look at.
This commit is contained in:
Kyle K 2019-07-21 00:37:10 +00:00
parent 4e7fd3e2dc
commit 5d8958a9a0
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/js/jenkins_loader.js
View file

@ -13,8 +13,8 @@ JenkinsLoader.prototype.loadJobs = function (viewName, callback) {
var self = this;
var viewUrl = `${self._url}/view/${viewName}`;
var jobsDataTag = '${viewUrl}JobsData';
var cacheLastUpdateTag = '${viewUrl}JobsLastUpdate';
var jobsDataTag = `${viewUrl}_JobsData`;
var cacheLastUpdateTag = `${viewUrl}_JobsLastUpdate`;
var wrappedCallback = jobs => {
self._jobs = jobs;