Mirror/betaflight
1
0
Fork 0
mirror of https://github.com/betaflight/betaflight.git synced 2025-07-15 12:25:20 +03:00
Code Issues Wiki Activity

ELRS/SX127x - Cleanup NVIC/atomic block usage.

Browse source 
Since #11380 the sx127xISR will always be called from an ISR handler so
no additional NVIC entry or ATOMIC_BLOCK is required.

Also, since sx127xISR is always called from an ISR handler it means that
there's no need to call rxSpiPollExti.
This commit is contained in:
Dominic Clifton 2022-03-07 15:28:53 +01:00
parent 70a1b59687
commit d43cb26b8e
1 changed files with 7 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/main/drivers/rx/rx_sx127x.c
View file

@ -76,27 +76,16 @@ static bool sx127xDetectChip(void)
uint8_t sx127xISR(timeUs_t *timeStamp) uint8_t sx127xISR(timeUs_t *timeStamp)
{ {
bool extiTriggered = false; timeUs_t extiTimestamp = rxSpiGetLastExtiTimeUs();
timeUs_t extiTimestamp;
ATOMIC_BLOCK(NVIC_PRIO_RX_SPI_INT_EXTI) { rxSpiResetExti();
// prevent a data-race that can occur if a new EXTI ISR occurs during this block.
extiTriggered = rxSpiPollExti(); uint8_t irqReason = sx127xGetIrqReason();
extiTimestamp = rxSpiGetLastExtiTimeUs(); if (extiTimestamp) {
if (extiTriggered) { *timeStamp = extiTimestamp;
rxSpiResetExti();
}
} }
if (extiTriggered) { return irqReason;
uint8_t irqReason = sx127xGetIrqReason();
if (extiTimestamp) {
*timeStamp = extiTimestamp;
}
return irqReason;
}
return 0;
} }
bool sx127xInit(IO_t resetPin, IO_t busyPin) bool sx127xInit(IO_t resetPin, IO_t busyPin)