NekoCWD/libcamera
NekoCWD/libcamera
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 7 Wiki Activity Actions

libcamera: Don't use emitter object pointer argument to slot

Browse source 
In many cases, the emitter object passed as a pointer from signals to
slots is also available as a class member. Use the class member when
this occurs, to prepare for removal of the emitter object pointer from
signals.

In test/event.cpp, this additionally requires moving the EventNotifier
to a class member.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
This commit is contained in:
Laurent Pinchart 2021-08-27 04:41:05 +03:00
parent 58720e1dc9
commit 3f662ae3c0
7 changed files with 25 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
utils/ipc/generators/libcamera_templates/module_ipa_proxy_worker.cpp.tmpl
View file

@ -57,10 +57,10 @@ public:
~{{proxy_worker_name}}() {}
void readyRead(IPCUnixSocket *socket)
void readyRead([[maybe_unused]] IPCUnixSocket *socket)
{
IPCUnixSocket::Payload _message;
int _retRecv = socket->receive(&_message);
int _retRecv = socket_.receive(&_message);
if (_retRecv) {
LOG({{proxy_worker_name}}, Error)
<< "Receive message failed: " << _retRecv;