libcamera: buffer: Rename buffer.h to framebuffer.h

libcamera names header files based on the classes they define. The
buffer.h file is an exception. Rename it to framebuffer.h.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

include/libcamera/framebuffer.h

@@ -2,10 +2,10 @@
 /*
  * Copyright (C) 2019, Google Inc.
  *
- * buffer.h - Buffer handling
+ * framebuffer.h - Frame buffer handling
  */
-#ifndef __LIBCAMERA_BUFFER_H__
+#ifndef __LIBCAMERA_FRAMEBUFFER_H__
-#define __LIBCAMERA_BUFFER_H__
+#define __LIBCAMERA_FRAMEBUFFER_H__
 
 #include <stdint.h>
 #include <vector>
@@ -71,4 +71,4 @@ private:
 
 } /* namespace libcamera */
 
-#endif /* __LIBCAMERA_BUFFER_H__ */
+#endif /* __LIBCAMERA_FRAMEBUFFER_H__ */

include/libcamera/internal/framebuffer.h

@@ -2,10 +2,10 @@
 /*
  * Copyright (C) 2020, Google Inc.
  *
- * buffer.h - Internal buffer handling
+ * framebuffer.h - Internal frame buffer handling
  */
-#ifndef __LIBCAMERA_INTERNAL_BUFFER_H__
+#ifndef __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__
-#define __LIBCAMERA_INTERNAL_BUFFER_H__
+#define __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__
 
 #include <sys/mman.h>
 #include <vector>
@@ -13,7 +13,7 @@
 #include <libcamera/base/class.h>
 #include <libcamera/base/span.h>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 namespace libcamera {
 
@@ -49,4 +49,4 @@ public:
 
 } /* namespace libcamera */
 
-#endif /* __LIBCAMERA_INTERNAL_BUFFER_H__ */
+#endif /* __LIBCAMERA_INTERNAL_FRAMEBUFFER_H__ */

include/libcamera/internal/ipa_data_serializer.h

@@ -16,8 +16,8 @@
 
 #include <libcamera/base/log.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/control_ids.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/geometry.h>
 #include <libcamera/ipa/ipa_interface.h>
 

include/libcamera/internal/meson.build

@@ -11,7 +11,6 @@ libcamera_tracepoint_header = custom_target(
 
 libcamera_internal_headers = files([
     'bayer_format.h',
-    'buffer.h',
     'byte_stream_buffer.h',
     'camera_controls.h',
     'camera_sensor.h',
@@ -23,6 +22,7 @@ libcamera_internal_headers = files([
     'device_enumerator_sysfs.h',
     'device_enumerator_udev.h',
     'formats.h',
+    'framebuffer.h',
     'ipa_manager.h',
     'ipa_module.h',
     'ipa_proxy.h',

include/libcamera/internal/tracepoints/request.tp

@@ -5,7 +5,7 @@
  * request.tp - Tracepoints for the request object
  */
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/request.h>
 
 TRACEPOINT_EVENT_CLASS(

include/libcamera/internal/v4l2_videodevice.h

@@ -20,7 +20,7 @@
 #include <libcamera/base/log.h>
 #include <libcamera/base/signal.h>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/geometry.h>
 #include <libcamera/pixel_format.h>
 

include/libcamera/ipa/ipa_interface.h

@@ -15,8 +15,8 @@
 
 #include <libcamera/base/signal.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/controls.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/geometry.h>
 
 namespace libcamera {

include/libcamera/meson.build

@@ -1,12 +1,12 @@
 # SPDX-License-Identifier: CC0-1.0
 
 libcamera_public_headers = files([
-    'buffer.h',
     'camera.h',
     'camera_manager.h',
     'compiler.h',
     'controls.h',
     'file_descriptor.h',
+    'framebuffer.h',
     'framebuffer_allocator.h',
     'geometry.h',
     'logging.h',

include/libcamera/stream.h

@@ -12,7 +12,7 @@
 #include <string>
 #include <vector>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/geometry.h>
 #include <libcamera/pixel_format.h>
 

src/android/camera_device.h

@@ -19,12 +19,12 @@
 #include <libcamera/base/message.h>
 #include <libcamera/base/thread.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include "camera_capabilities.h"
 #include "camera_metadata.h"

src/android/camera_stream.h

@@ -13,13 +13,13 @@
 
 #include <hardware/camera3.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/framebuffer_allocator.h>
 #include <libcamera/geometry.h>
 #include <libcamera/pixel_format.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 class CameraDevice;
 class CameraMetadata;

src/android/camera_worker.h

@@ -12,8 +12,8 @@
 #include <libcamera/base/object.h>
 #include <libcamera/base/thread.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/request.h>
 #include <libcamera/stream.h>
 

src/android/jpeg/encoder.h

@@ -9,7 +9,7 @@
 
 #include <libcamera/base/span.h>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/stream.h>
 
 class Encoder

src/android/jpeg/encoder_libjpeg.h

@@ -9,8 +9,8 @@
 
 #include "encoder.h"
 
-#include "libcamera/internal/buffer.h"
 #include "libcamera/internal/formats.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include <jpeglib.h>
 

src/android/jpeg/post_processor_jpeg.h

@@ -13,7 +13,7 @@
 
 #include <libcamera/geometry.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 class CameraDevice;
 

src/android/jpeg/thumbnailer.h

@@ -9,8 +9,8 @@
 
 #include <libcamera/geometry.h>
 
-#include "libcamera/internal/buffer.h"
 #include "libcamera/internal/formats.h"
+#include "libcamera/internal/framebuffer.h"
 
 class Thumbnailer
 {

src/android/mm/generic_camera_buffer.cpp

@@ -11,7 +11,7 @@
 
 #include <libcamera/base/log.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 using namespace libcamera;
 

src/android/post_processor.h

@@ -7,10 +7,10 @@
 #ifndef __ANDROID_POST_PROCESSOR_H__
 #define __ANDROID_POST_PROCESSOR_H__
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/stream.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include "camera_buffer.h"
 

src/cam/buffer_writer.h

@@ -10,7 +10,7 @@
 #include <map>
 #include <string>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 class BufferWriter
 {

src/cam/capture.h

@@ -11,8 +11,8 @@
 #include <stdint.h>
 #include <vector>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/framebuffer_allocator.h>
 #include <libcamera/request.h>
 #include <libcamera/stream.h>

src/ipa/ipu3/ipu3.cpp

@@ -13,14 +13,14 @@
 
 #include <libcamera/base/log.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/control_ids.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/ipu3_ipa_interface.h>
 #include <libcamera/request.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include "ipu3_agc.h"
 #include "ipu3_awb.h"

src/ipa/raspberrypi/raspberrypi.cpp

@@ -18,17 +18,17 @@
 #include <libcamera/base/log.h>
 #include <libcamera/base/span.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/control_ids.h>
 #include <libcamera/controls.h>
 #include <libcamera/file_descriptor.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/raspberrypi.h>
 #include <libcamera/ipa/raspberrypi_ipa_interface.h>
 #include <libcamera/request.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include "agc_algorithm.hpp"
 #include "agc_status.h"

src/ipa/rkisp1/rkisp1.cpp

@@ -17,8 +17,8 @@
 
 #include <libcamera/base/log.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/control_ids.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/ipa/ipa_interface.h>
 #include <libcamera/ipa/ipa_module_info.h>
 #include <libcamera/ipa/rkisp1_ipa_interface.h>

src/libcamera/framebuffer.cpp

@@ -2,11 +2,11 @@
 /*
  * Copyright (C) 2019, Google Inc.
  *
- * buffer.cpp - Buffer handling
+ * framebuffer.cpp - Frame buffer handling
  */
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include <errno.h>
 #include <string.h>
@@ -16,11 +16,11 @@
 #include <libcamera/base/log.h>
 
 /**
- * \file libcamera/buffer.h
+ * \file libcamera/framebuffer.h
- * \brief Buffer handling
+ * \brief Frame buffer handling
  *
- * \file libcamera/internal/buffer.h
+ * \file libcamera/internal/framebuffer.h
- * \brief Internal buffer handling support
+ * \brief Internal frame buffer handling support
  */
 
 namespace libcamera {

src/libcamera/framebuffer_allocator.cpp

@@ -11,8 +11,8 @@
 
 #include <libcamera/base/log.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/stream.h>
 
 #include "libcamera/internal/pipeline_handler.h"

src/libcamera/meson.build

@@ -2,7 +2,6 @@
 
 libcamera_sources = files([
     'bayer_format.cpp',
-    'buffer.cpp',
     'byte_stream_buffer.cpp',
     'camera.cpp',
     'camera_controls.cpp',
@@ -17,6 +16,7 @@ libcamera_sources = files([
     'device_enumerator_sysfs.cpp',
     'file_descriptor.cpp',
     'formats.cpp',
+    'framebuffer.cpp',
     'framebuffer_allocator.cpp',
     'geometry.cpp',
     'ipa_controls.cpp',

src/libcamera/pipeline/ipu3/frames.cpp

@@ -7,7 +7,7 @@
 
 #include "frames.h"
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/request.h>
 
 #include "libcamera/internal/pipeline_handler.h"

src/libcamera/pipeline/raspberrypi/raspberrypi.cpp

@@ -30,10 +30,10 @@
 #include <linux/videodev2.h>
 
 #include "libcamera/internal/bayer_format.h"
-#include "libcamera/internal/buffer.h"
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/delayed_controls.h"
 #include "libcamera/internal/device_enumerator.h"
+#include "libcamera/internal/framebuffer.h"
 #include "libcamera/internal/ipa_manager.h"
 #include "libcamera/internal/media_device.h"
 #include "libcamera/internal/pipeline_handler.h"

src/libcamera/pipeline/rkisp1/rkisp1.cpp

@@ -17,10 +17,10 @@
 #include <libcamera/base/log.h>
 #include <libcamera/base/utils.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/control_ids.h>
 #include <libcamera/formats.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/ipa/core_ipa_interface.h>
 #include <libcamera/ipa/rkisp1_ipa_interface.h>
 #include <libcamera/ipa/rkisp1_ipa_proxy.h>

src/libcamera/pipeline/simple/converter.cpp

@@ -14,7 +14,7 @@
 #include <libcamera/base/signal.h>
 #include <libcamera/base/utils.h>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/geometry.h>
 #include <libcamera/stream.h>
 

src/libcamera/pipeline_handler.cpp

@@ -12,9 +12,9 @@
 #include <libcamera/base/log.h>
 #include <libcamera/base/utils.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/camera_manager.h>
+#include <libcamera/framebuffer.h>
 
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/media_device.h"

src/libcamera/request.cpp

@@ -12,9 +12,9 @@
 
 #include <libcamera/base/log.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/control_ids.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/stream.h>
 
 #include "libcamera/internal/camera_controls.h"

src/qcam/dng_writer.h

@@ -10,9 +10,9 @@
 #ifdef HAVE_TIFF
 #define HAVE_DNG
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/controls.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/stream.h>
 
 using namespace libcamera;

src/qcam/main_window.h

@@ -18,10 +18,10 @@
 #include <QQueue>
 #include <QTimer>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/camera_manager.h>
 #include <libcamera/controls.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/framebuffer_allocator.h>
 #include <libcamera/request.h>
 #include <libcamera/stream.h>

src/qcam/viewfinder.h

@@ -11,8 +11,8 @@
 #include <QList>
 #include <QSize>
 
-#include <libcamera/buffer.h>
 #include <libcamera/formats.h>
+#include <libcamera/framebuffer.h>
 
 struct MappedBuffer {
 	void *memory;

src/qcam/viewfinder_gl.h

@@ -21,8 +21,8 @@
 #include <QOpenGLWidget>
 #include <QSize>
 
-#include <libcamera/buffer.h>
 #include <libcamera/formats.h>
+#include <libcamera/framebuffer.h>
 
 #include "viewfinder.h"
 

src/qcam/viewfinder_qt.h

@@ -14,8 +14,8 @@
 #include <QSize>
 #include <QWidget>
 
-#include <libcamera/buffer.h>
 #include <libcamera/formats.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/pixel_format.h>
 
 #include "format_converter.h"

src/v4l2/v4l2_camera.h

@@ -14,9 +14,9 @@
 
 #include <libcamera/base/semaphore.h>
 
-#include <libcamera/buffer.h>
 #include <libcamera/camera.h>
 #include <libcamera/file_descriptor.h>
+#include <libcamera/framebuffer.h>
 #include <libcamera/framebuffer_allocator.h>
 
 using namespace libcamera;

test/mapped-buffer.cpp

@@ -9,7 +9,7 @@
 
 #include <libcamera/framebuffer_allocator.h>
 
-#include "libcamera/internal/buffer.h"
+#include "libcamera/internal/framebuffer.h"
 
 #include "camera_test.h"
 #include "test.h"

test/v4l2_subdevice/v4l2_subdevice_test.h

@@ -8,7 +8,7 @@
 #ifndef __LIBCAMERA_V4L2_SUBDEVICE_TEST_H__
 #define __LIBCAMERA_V4L2_SUBDEVICE_TEST_H__
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/media_device.h"

test/v4l2_videodevice/buffer_sharing.cpp

@@ -12,7 +12,7 @@
 
 #include <iostream>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 #include <libcamera/base/event_dispatcher.h>
 #include <libcamera/base/thread.h>

test/v4l2_videodevice/capture_async.cpp

@@ -7,7 +7,7 @@
 
 #include <iostream>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 #include <libcamera/base/event_dispatcher.h>
 #include <libcamera/base/thread.h>

test/v4l2_videodevice/v4l2_m2mdevice.cpp

@@ -7,7 +7,7 @@
 
 #include <iostream>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 #include <libcamera/base/event_dispatcher.h>
 #include <libcamera/base/thread.h>

test/v4l2_videodevice/v4l2_videodevice_test.h

@@ -9,7 +9,7 @@
 
 #include <memory>
 
-#include <libcamera/buffer.h>
+#include <libcamera/framebuffer.h>
 
 #include "libcamera/internal/camera_sensor.h"
 #include "libcamera/internal/device_enumerator.h"