libcamera/test/controls/control_value.cpp
Laurent Pinchart 224ef9776a libcamera: controls: Make ControlValue get/set accessors template methods
The ControlValue get accessors are implemented with functions of
different names, whlie the set accessors use polymorphism to support
different control types. This isn't very consistent and intuitive. Make
the API clearer by using template methods. This will also have the added
advantage that support for the new types will only require adding
template specialisations, without adding new methods.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
2019-10-04 19:33:08 +03:00

69 lines
1.3 KiB
C++

/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* Copyright (C) 2019, Google Inc.
*
* control_value.cpp - ControlValue tests
*/
#include <iostream>
#include <libcamera/controls.h>
#include "test.h"
using namespace std;
using namespace libcamera;
class ControlValueTest : public Test
{
protected:
int run()
{
ControlValue integer(1234);
ControlValue boolean(true);
/* Just a string conversion output test... no validation */
cout << "Int: " << integer.toString()
<< " Bool: " << boolean.toString()
<< endl;
if (integer.get<int>() != 1234) {
cerr << "Failed to get Integer" << endl;
return TestFail;
}
if (boolean.get<bool>() != true) {
cerr << "Failed to get Boolean" << endl;
return TestFail;
}
/* Test an uninitialised value, and updating it. */
ControlValue value;
if (!value.isNone()) {
cerr << "Empty value is non-null" << endl;
return TestFail;
}
value.set<bool>(true);
if (value.isNone()) {
cerr << "Failed to set an empty object" << endl;
return TestFail;
}
if (value.get<bool>() != true) {
cerr << "Failed to get Booleans" << endl;
return TestFail;
}
value.set<int>(10);
if (value.get<int>() != 10) {
cerr << "Failed to get Integer" << endl;
return TestFail;
}
return TestPass;
}
};
TEST_REGISTER(ControlValueTest)