1
0
Fork 0
mirror of https://github.com/betaflight/betaflight.git synced 2025-07-15 04:15:44 +03:00
Commit graph

16486 commits

Author SHA1 Message Date
Bruce Luckcuck
35adb5ba06 Only register CMS displayPort for SRXL and CRSF when appropriate
Previous logic was always registering CRSL and SRXL as CMS displayPort devices regardless of whether the user was actually using that type of radio and telemetry.

The problem this caused is that if the user accidentally (or intentionally) used the CMS invoke stick command while already in the CMS on the MAX7456 the logic interprets this to mean "switch to the next registered displayPort device". So in this case the CMS would appear to exit based on what the user could see. But in reality it's still active and simply switched to the next (nonexistent) device. The user is then stuck and can't arm because the `CMS` arming disabled will be active and they have no way to interact with the CMS. They can technically blindly do the CMS stick command 2 more times to get back to the MAX7456, but how would they know that?

So this change only registers the CRSF and SRXL displayPorts when the user has selected those receiver types and enabled telemetry.

This is actually only a partial solution since it prevents registering the devices when they're impossible to work, but doesn't do anything for the actual CRSF or SRXL user that may be using equipment not capable of displaying the CMS. So it's still possible for them to get stuck in this situation. But I don't see any reasonable way to prevent this.

Perhaps it's time to rethink this "Switch to next CMS device" logic? It's something that nobody really knows about and seems to be more trouble than value. Maybe there are some edge cases where it's useful like using the OLED dashboard along with a MAX7456, but that's a rare use-case. Or possibly we need some explicit control where the user has to enable the particular displayPort device to be eligible for CMS?
2021-01-04 12:20:02 -05:00
Michael Keller
932d6dc153
Merge pull request #10434 from tstibor/unused_cli_variables
Remove unused CLI variables from documentation page
2021-01-01 13:04:53 +01:00
Michael Keller
20940de41d
Merge pull request #10430 from etracer65/improve_rates_range_checks
Improve rate settings range checking
2021-01-01 01:43:39 +01:00
Bruce Luckcuck
3c15716679 Improve rate settings range checking
Improve the logic to be table-based and add validation of the rc_rates and expo values. The previous logic only validated the super-rates and the rc_rates can also be out-of-range when changing rates types. The expo values are also checked but currently all the rates types have the same constraints so there's no possibility currently of them being out of range. But this will allow for possible new rates type that have different constraints.
2020-12-31 18:52:07 -05:00
Michael Keller
2126aa17e6
Merge pull request #10429 from etracer65/fix_raceflight_rate_reset
Fix logic error for RACEFLIGHT and KISS rates range checks
2021-01-01 00:39:24 +01:00
Michael Keller
b5477cd500
Merge pull request #10408 from mikeller/cleanup_debug_code
Cleaned up debug code in Dshot.
2020-12-30 16:14:33 +01:00
Michael Keller
74297459f0
Merge pull request #10407 from mikeller/fix_dshot_command_msp
Fixed MSP command to send Dshot commands.
2020-12-30 16:14:19 +01:00
Thomas Stibor
a974891432 Remove unused CLI variables from documentation page
Since version 4.0.0 CLI variables:

    * acc_cut_hz,
    * accxy_deadband,
    * accz_deadband,
    * acc_unarmedcal

are removed from settings.c and thus can be also removed
from the CLI documentation page.
2020-12-30 14:42:26 +01:00
Bruce Luckcuck
76d50f1d37 Fix logic error for RACEFLIGHT and KISS rates range checks
Fixes logic errors in #9574

For RACEFLIGHT rates the applicable `case` was missing so the logic defaulted to the BETAFLIGHT rates logic which incorrectly limited the maximum rate value to 100. RACEFLIGHT values range to 255.

For KISS rates the limit was set to 100 but the Configurator constrains to 99.
2020-12-27 18:14:16 -05:00
Michael Keller
32373e3e05
Merge pull request #10426 from mikeller/improve_issue_templates
Remove heading for 'Additional Context' from issue templates, improve clarity.
2020-12-27 21:30:43 +01:00
Michael Keller
9fe4141342
Merge pull request #10425 from etracer65/fix_cellcount_div0
Fix multiple div-by-zero related to battery cell count
2020-12-27 01:06:23 +01:00
Michael Keller
50c149821d
Merge pull request #10424 from etracer65/improve_osd_blink
Improve OSD blink timing logic
2020-12-27 01:05:53 +01:00
Michael Keller
4d9f2c330b
Merge pull request #10406 from mikeller/fix_bitbanged_dshot_commands
Fixed problem when sending blocking Dshot commands with bitbanged Dshot enabled.
2020-12-26 02:32:52 +01:00
Michael Keller
5a443f1824
Merge pull request #10419 from Linjieqiang/add_more_flash_support_aio
Add more flash chip support for IFLIGHT_H743_AIO board.
2020-12-26 02:19:07 +01:00
Michael Keller
518918899f Remove heading for 'Additional Context' from issue templates, improve clarity. 2020-12-25 21:20:20 +01:00
Bruce Luckcuck
01fb3940e7 Fix multiple div-by-zero related to battery cell count
Battery cell count will be 0 if the battery is not detected or the voltage meter is not configured. This exposed multiple div-by-zero risks.
2020-12-25 14:17:00 -05:00
Bruce Luckcuck
f7d992b2bd Improve OSD blink logic
Changes the blink logic to be OSD task loop based instead of time based.

The previous logic used a 200ms time interval for the blinking which didn't align well with the default 12hz OSD update frequency resulting in the logic periodically missing intervals resulting in an inconsistent blinking.

As the revised logic is now tied to the OSD task iterations the blinking will be consistent. However due to the timing the blink will be slightly faster - 167ms (6hz) vs. the previous 200ms (5hz) intervals. Technically the blinking was 6hz before but stuttered every 5th blink.

Since the OSD task rate can be changed from the default 60hz, the logic will fall back to the time-based implementation for non-default task rates.
2020-12-25 12:41:44 -05:00
LinJieqiang
d6ec351c36 Add more flash chip support for IFLIGHT_H745_AIO board. 2020-12-22 22:03:38 +08:00
Michael Keller
3f116fd103
Merge pull request #10416 from mikeller/enable_azure_pull_request_builds 2020-12-22 10:54:13 +01:00
Michael Keller
6fb0d2a2ca Changed to build all targets. 2020-12-22 10:03:11 +01:00
Michael Keller
28490f5972 Enabled pull request builds in Azure. 2020-12-22 10:03:11 +01:00
Michael Keller
e24c24cbf2
Merge pull request #10409 from mikeller/fix_nucleoh743_rambased_overflow 2020-12-22 10:02:40 +01:00
Michael Keller
364b9e0f88
Merge pull request #10382 from McGiverGim/auto_close_issues 2020-12-17 00:43:04 +01:00
Miguel Angel Mulero Martinez
f9780e95c1 Add action to close issues 2020-12-16 16:00:28 +01:00
Michael Keller
f39b00ea54
Merge pull request #10405 from mikeller/fix_rssi_dbm_warning_cli
Added missing CLI parameter for RSSI dBm.
2020-12-16 14:09:30 +01:00
Michael Keller
00a75326c0 Fixed RAM overflow on NUCLEOH743_RAMBASED. 2020-12-16 01:16:59 +01:00
Michael Keller
d89a5c8713
Merge pull request #10389 from ImmersionRC/irc-ghst-driver-debug 2020-12-16 01:05:54 +01:00
Michael Keller
834ce7c5eb Cleaned up debug code in Dshot. 2020-12-16 00:37:31 +01:00
Michael Keller
d36c62d092
Merge pull request #10403 from haslinghuis/make-tests-with-clang11-linux 2020-12-15 22:19:12 +01:00
Mark Haslinghuis
d596e259a0 Make test compatible with clang 11 on linux 2020-12-15 21:02:46 +01:00
Michael Keller
f91783571a
Merge pull request #10402 from mikeller/remove_deprecated_dshot_commands
Removed deprecated Dshot commands to enable / disable bidirectional Dshot.
2020-12-15 16:54:55 +01:00
Michael Keller
0b81b26ce0 Fixed MSP command to send Dshot commands. 2020-12-15 16:12:11 +01:00
anthonycake
81150286c6 Keep reviewers happy 2020-12-15 09:02:01 +01:00
Michael Keller
d43e06d3e3
Merge pull request #10378 from SteveCEvans/h7led 2020-12-15 08:51:15 +01:00
Michael Keller
bfa5cc1cd4 Fixed problem when sending blocking Dshot commands with bitbanged Dshot enabled. 2020-12-15 02:29:39 +01:00
Steve Evans
cb908a6893 Add USE_LEDSTRIP_CACHE_MGMT option to use explicit cache management for LED strip.
Ensure DMA_RAM section is at start of RAM and the the region defining the shareable region is covered.
Enable USE_LEDSTRIP_CACHE_MGMT on NUCLEOH743 target
2020-12-14 19:35:13 +00:00
Michael Keller
97a647f36a Added missing CLI parameter for RSSI dBm. 2020-12-14 20:28:54 +01:00
Michael Keller
98b634adcd Removed deprecated Dshot commands to enable / disable bidirectional Dshot. 2020-12-12 21:35:29 +01:00
Michael Keller
57c9c12781
Merge pull request #10383 from mluessi/ml_h7_dshot_opt 2020-12-09 15:40:16 +01:00
Martin Luessi
b46971f1f0 Fix style 2020-12-09 05:43:51 -08:00
Michael Keller
34e6a83f70
Merge pull request #10370 from borisbstyle/new_mixer 2020-12-08 12:07:41 +01:00
borisbstyle
4a916af6a9 Added DYNAMIC mixer 2020-12-08 12:04:18 +01:00
borisbstyle
75da17a00e New linear mixer (credits to @tylercorleone) 2020-12-08 12:04:07 +01:00
Michael Keller
7154abc48e
Merge pull request #10348 from pgreenland/vtx_irc_tramp_logic_pitmode_cli
Fix VTX tramp protocol for all
2020-12-08 10:56:45 +01:00
Michael Keller
203398299e
Merge pull request #10388 from ImmersionRC/irc-uart-bidir-fix 2020-12-07 11:56:16 +01:00
anthonycake
481d42c3da Remove stray whitespace 2020-12-06 16:07:23 +01:00
Phil Greenland
e1eba3fdda Review updates. Remove new CLI option in anticipation of fix from Mateksys. 2020-12-06 11:32:05 +00:00
anthonycake
a543ed8887 Switch to static storage for error counters
Remove DEBUG_INCR, and switch to static counters.
2020-12-05 17:42:56 +01:00
anthonycake
8627af832c Add debug support to GHST protocol driver
Add ability for pilots to log CRC errors, unknown frames, LQ, and RSSI. 
Added macro to debug.h to simplify incrementing debug values without the need for local statics in client code.
2020-12-05 12:17:38 +01:00
anthonycake
1f0fbf6a65 Fix BIDIR UART issue #10220
Fix the issue described in Issue #10220, typos in serial drivers for F7, F3, G4, H7 platforms. 
Before this change, the serial line is incorrectly pulled down for bidirectional comms, which may cause dropped packets (silently) with any Rx protocol that uses bidirectional comms on the Tx line (GHST, SRXL-2, FPORT)
2020-12-04 18:11:17 +01:00